Handle another case of incomplete reads from S3-type storage (OVH S3) #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure that any botocore ResponseStreamingErrors are handled and retried in a similar way to botocore IncompleteReadErrors. * This type of error appears to be frequently raised when using OVH S3 storage, resulting in a failure to download the file.
bridgetb
force-pushed
the
bridgetb/handle-botocore-error
branch
from
8e5d729 to
4bbbc44
Compare
edward-evans-aiven
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Ensure that any botocore ResponseStreamingErrors are handled and retried in a similar way to botocore IncompleteReadErrors.
Catch
botocore.exceptions.ResponseStreamingErroringet_contents_to_fileobj()and retry the get object request from the point before it failed.Resolves: This type of error appears to be frequently raised when downloading larger files from OVH S3 storage with a later version of urllib3 (1.26-2.3, exact version unknown), resulting in a failure to download the file.
Why this way