-
Notifications
You must be signed in to change notification settings - Fork 50
Labels
Maintainer: coxmarsbackenddifficulty: mediumonlydust-waveContribute to awesome OSS repos during OnlyDust's open source weekContribute to awesome OSS repos during OnlyDust's open source week
Description
📝 Fix Store.cairo TODOs and Experience System
🔍 Scope
Complete pending TODOs in store.cairo and integrate ExperienceCalculatorTrait properly.
🔄 How to Implement the Issue
- Import ExperienceCalculatorTrait from
helpers/experience_utils.cairo - Replace hardcoded values in
award_battle_experience()with trait methods - Add BASE_BATTLE_EXPERIENCE constant to constants.cairo
- Update experience logic in
process_attack()method
✅ Acceptance Criteria
- ExperienceCalculatorTrait imported and used in store.cairo
- Remove hardcoded experience values (10, 5, 1)
- Add BASE_BATTLE_EXPERIENCE constant
- All TODO comments resolved
- Tests pass with
sozo test
📸 Additional Context
TODO locations:
- Line ~120: ExperienceCalculatorTrait not implemented
- Line ~127: ExperienceCalculatorTrait not implemented
- Line ~181: Define base experience for winning
Contribution Guidelines
- Please ensure you read and follow the contribution guidelines in the project's README file
Metadata
Metadata
Assignees
Labels
Maintainer: coxmarsbackenddifficulty: mediumonlydust-waveContribute to awesome OSS repos during OnlyDust's open source weekContribute to awesome OSS repos during OnlyDust's open source week