Set RequestMessage in matched StubbedResponse #15
Conversation
When running AcceptanceTests for error scenarios using Refit, it throws null reference exception. This is caused by refit trying to access response.RequestMessage.Method while response.RequestMessage is null. This change resolves that issue by setting the original request as response.RequestMessage. It will also help if any tested code is accessing response.RequestMessage. The refit method that throws null reference exception https://github.com/reactiveui/refit/blob/569108a65079d364647f06437f977df8145fc578/Refit/RefitSettings.cs#L233
|
Is there any additional information we can provide that would make the review easier? |
AlanCS
left a comment
AlanCS
left a comment
There was a problem hiding this comment.
good improvement, thanks for posting it
no, it was well documented in the first place :) |
|
https://www.nuget.org/packages/SystemTestingTools/2.0.32 is the version with this fix ! just out of curiosity, how is the adoption of component testing instead of unit testing everything at your company ? no need to disclose the company or any details if you don't feel confortable to do so ! |
|
unit testing is still the most common style of test. stubbed acceptance tests are definitely getting a lot more effort nowadays though :) |
3 participants
When running AcceptanceTests for error scenarios using Refit, it throws null reference exception. This is caused by refit trying to access response.RequestMessage.Method while response.RequestMessage is null. This change resolves that issue by setting the original request as response.RequestMessage. It will also help if any tested code is accessing response.RequestMessage.
The refit method that throws null reference exception https://github.com/reactiveui/refit/blob/569108a65079d364647f06437f977df8145fc578/Refit/RefitSettings.cs#L233