Skip to content

Made Note About gem propshaft in README.md#3386

Merged
tvdeyen merged 3 commits intoAlchemyCMS:mainfrom
Ted-Tash:propshaft-note-issue-3330
Sep 30, 2025
Merged

Made Note About gem propshaft in README.md#3386
tvdeyen merged 3 commits intoAlchemyCMS:mainfrom
Ted-Tash:propshaft-note-issue-3330

Conversation

@Ted-Tash
Copy link
Copy Markdown
Contributor

@Ted-Tash Ted-Tash commented Sep 30, 2025

What is this pull request for?

Adding a note about propshaft compatibility for older rails versions, with encouragement to use alchemy ~> 8.0.0a if on `Rails >8. Taken from this comment.

Closes #3330

image

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change --> this is a documentation only change 😃

@Ted-Tash Ted-Tash requested a review from a team as a code owner September 30, 2025 14:18
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.99%. Comparing base (6afea50) to head (297ca35).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3386   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files         277      277           
  Lines        7262     7262           
=======================================
  Hits         7044     7044           
  Misses        218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Ted-Tash
Copy link
Copy Markdown
Contributor Author

@tvdeyen with the note block:

image

@Ted-Tash Ted-Tash requested a review from tvdeyen September 30, 2025 19:42
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tvdeyen tvdeyen merged commit c6bad55 into AlchemyCMS:main Sep 30, 2025
18 checks passed
@alchemycms-bot alchemycms-bot bot mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors in new Rails 8.0 app with propshaft

2 participants