Skip to content

Allow scrolling of left menu on small screens#3717

Draft
kulturbande wants to merge 1 commit intoAlchemyCMS:mainfrom
kulturbande:scrolling-left-menu
Draft

Allow scrolling of left menu on small screens#3717
kulturbande wants to merge 1 commit intoAlchemyCMS:mainfrom
kulturbande:scrolling-left-menu

Conversation

@kulturbande
Copy link
Contributor

@kulturbande kulturbande commented Mar 1, 2026

What is this pull request for?

Add the dynamic viewport height to 100 to set to the browser height without address bar. The old height values remain in place for older browsers. The overflow configuration does not do any harm on bigger screens and can be added without a media query.

Screenshots

Before:

Aufnahme.2026-03-01.at.21.19.41.mp4

After:

Aufnahme.2026-03-01.at.21.20.27.mp4

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Add the dynamic viewport height to 100 to set to the browser height
without address bar. The old height values remain in place
for older browsers. The overflow configuration does not do any harm
on bigger screens and can be added without a media query.
@kulturbande kulturbande requested a review from a team as a code owner March 1, 2026 20:21
@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.47%. Comparing base (4c2023f) to head (00262c2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3717   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         314      314           
  Lines        8304     8304           
=======================================
  Hits         8094     8094           
  Misses        210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the flyout menues still work on medium screens with collapsed menu?

overflow-y: auto;
-webkit-overflow-scrolling: touch;
}
overflow-x: hidden;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having that without the media query, we wont see any of the flyout menues anymore, right?

@tvdeyen tvdeyen marked this pull request as draft March 4, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants