-
Notifications
You must be signed in to change notification settings - Fork 6
What a selection operator could look like #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
anyzelman
merged 57 commits into
develop
from
635-provide-grb-select-out-matrix-in-matrix-lambda-bool
Mar 2, 2024
Merged
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
7cd8878
Draft of what a selection operator would look like
byjtew db3746e
Big commit, details...
byjtew b992a83
Implementation in nonblocking backend
byjtew 09a893e
Implementation in hyperdags backend, compiles but fails
byjtew f7e9f9f
Fix hyperdags implementation
byjtew 3016610
Implement selectLambda for reference+omp backend
byjtew ff564f8
Declaration of select+Lambda in base
byjtew 014c47e
Implement selectLambda for nonblocking backend
byjtew 6e6c716
Implement selectLambda for hyperdags backend
byjtew 82670ad
Distributed backend implementation
byjtew 64c7e71
Namespaces and classes refactoring
byjtew 0b84a0d
Bugfix for local coordinates in a distributed case
byjtew 7310450
Bugfix for local coordinates OMP shared status
byjtew 40562b5
Typofix for BSP1D matrix local coordinates
byjtew 5c7f6b7
Update unit-tests CMakeLists.txt
byjtew 0fe175f
Bugfix in BSP1D primitive declaration
byjtew 2657d5f
Remove forbidden const for RC in bsp1d/blas3.hpp
byjtew dafefed
Handle trivial case
byjtew cd26ad9
Bugfix for distributed backends, still failing
byjtew 03c61b0
Local coordinates bugfix for distributed backends
byjtew a77710b
Small bugfixes, still failing in distributed mode
byjtew 62cc3bd
Final bugfix, unit-test extension, and preparation for testing with v…
byjtew 7b44c04
Yahouuuu the coordinates are fixed !!
byjtew dc3ce79
Merge select_generic and selectLambda_generic
byjtew 636ceb7
Documentation
byjtew bad0a3b
Syntax fixes
byjtew 1ce6c5c
Syntax fixes (2)
byjtew e66ec65
Syntax fixes (3)
byjtew f2fe02a
Minor fix for distributed
byjtew c23bca6
Review fixes
byjtew b40e81f
Review fix + void implementation
byjtew dfe06db
Merge branch 'develop' into 635-provide-grb-select-out-matrix-in-matr…
anyzelman 67892a0
Edits from code review -- most of them are quite minor, code style an…
anyzelman 029d6df
Compilation fix
byjtew 8661751
Review fixes
byjtew 96d335c
Simplify select API-- both lambdas and select operators now go to grb…
anyzelman c6ae7d2
Fix
byjtew 8cc1a27
Improve testing
byjtew 77685ab
Test reformat
byjtew 89cc41a
reference implementation reformat
byjtew 9dd1414
Evil pesky bugger
byjtew f4c5062
Remove unintented adds
anyzelman 581c42e
Fix script logic and style
anyzelman ca12dcf
Bugfix
anyzelman 700cd5f
Clean up hyperdags backend
anyzelman f8d3cb5
Merge branch 'develop' into 635-provide-grb-select-out-matrix-in-matr…
anyzelman b3faa71
Selection-by-lambda now expects const-references. Also some code styl…
anyzelman 4632535
Enable lambda-based selection with void data types in unit test
anyzelman 845ad4f
Clarify data types for selection operator
anyzelman e47688d
Final code review
anyzelman c6a8b30
Final code review -- clarify what the test does
anyzelman 66cf761
Unrelated code style fixes
anyzelman e30041d
Final code review fixes some border cases
anyzelman 74fd3d0
Code style fixes and test case where casting must happen within lambdas
anyzelman 93f4f0f
Final touches to user doc
anyzelman 5d82e9a
Final doc fix (I hope)
anyzelman 8ef2ac2
Minor code style fix
anyzelman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.