399 demo complex cg using std complex by djelovina · Pull Request #3 · Algebraic-Programming/ALP

This is a squashed version of the following commits:

Denis Jelovina

authored and

anyzelman

committed

revert hpcg to non-complex version

Denis Jelovina

authored and

anyzelman

committed

Revert HPCG

anyzelman

committed

eWiseMap to eWiseLambda, error checking, and (compile-time) conditional execution of lambdas

anyzelman

committed

Code review: the non-complex CG does not require a (conjugated) copy of a vector, this is now avoided. Removed some redundant statements near the end of the CG iteration loop. std::abs is not neces…

anyzelman

committed

Missed one instance where abs was used while modulus (in case of complex values) was intended. By recasting into is_complex::modulus, this operation now translates to no-op in the non-complex case

anyzelman

committed

Formatting issues in new code fixed. Bool casting of complex values no longer checks for equality to zero, but rather does a direct cast just as in the non-complex case. Since processing this file …

anyzelman

committed

Add noexcept to no-op implementations of conjugate and modulus

anyzelman

committed

Remove stray (old?) modification

anyzelman

committed

No need to use auto if the type is known

anyzelman

committed

Found two more uses of autos that are avoidable. One const-correctness fix.

anyzelman

committed

More descriptive names for hpchscalarbase and hpchscalar

anyzelman

committed

Move original test data rndHermit256.mtx into repository. Adapt CMake and bash scripts to new location.

anyzelman

committed

Remove external data location after having moved associated original data to repo

anyzelman

committed

Revert tools/downloadDatasets.sh to target branch version at head

anyzelman

committed

Revert hpcg/system_building_utils.hpp to latest state in develop

anyzelman

committed

Various small code style fixes and removing one superfluous include

anyzelman

committed

Else-if instead of sequence of ifs. Also catch unrecognised symmetry modes, and a small code style fix

anyzelman

committed

Remove superfluous spaces

anyzelman

committed

No need to always include complex header

anyzelman

committed

Did not correctly update smoketests.sh -- herewith fixed

anyzelman

committed

Do not use auto unnecessarily, use const-reference when reading out pinned vectors, rely on std::abs instead of fabs due to possible complex numbers, minor code style fixes, standard error handling…

anyzelman

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

399 demo complex cg using std complex#3

399 demo complex cg using std complex#3
anyzelman merged 22 commits intodevelopfrom
399-demo-complex-cg-using-std-complex

Commits on Apr 27, 2022

This is a squashed version of the following commits:

revert hpcg to non-complex version

Revert HPCG

eWiseMap to eWiseLambda, error checking, and (compile-time) conditional execution of lambdas

Code review: the non-complex CG does not require a (conjugated) copy of a vector, this is now avoided. Removed some redundant statements near the end of the CG iteration loop. std::abs is not neces…

Missed one instance where abs was used while modulus (in case of complex values) was intended. By recasting into is_complex::modulus, this operation now translates to no-op in the non-complex case

Formatting issues in new code fixed. Bool casting of complex values no longer checks for equality to zero, but rather does a direct cast just as in the non-complex case. Since processing this file …

Add noexcept to no-op implementations of conjugate and modulus

Remove stray (old?) modification

No need to use auto if the type is known

Found two more uses of autos that are avoidable. One const-correctness fix.

More descriptive names for hpchscalarbase and hpchscalar

Move original test data rndHermit256.mtx into repository. Adapt CMake and bash scripts to new location.

Remove external data location after having moved associated original data to repo

Revert tools/downloadDatasets.sh to target branch version at head

Revert hpcg/system_building_utils.hpp to latest state in develop

Various small code style fixes and removing one superfluous include

Else-if instead of sequence of ifs. Also catch unrecognised symmetry modes, and a small code style fix

Remove superfluous spaces

No need to always include complex header

Did not correctly update smoketests.sh -- herewith fixed

Do not use auto unnecessarily, use const-reference when reading out pinned vectors, rely on std::abs instead of fabs due to possible complex numbers, minor code style fixes, standard error handling…