363 missing grb wait for collecting execution times#364
Merged
Conversation
…e conditional and check the second wait
Member
|
Concept release notes: This MR adds calls to
This MR also improves, on occasion, error reporting, and, as always, includes code style fixes. Thank you to @aristeidis-mastoras for flagging these issues and providing the initial fixes! |
…le up to current standard
…es of all new waits. Remove unnecessary waits.)
…ide hot loops optional.
Member
|
Code review about 25% done (I thought this was an easy one, but alas...) |
…ror handling flow
…solve pre-existing bug where some error codes were not checked
…wait in the hot loop conditional (only if necessary), bugfix: some initialisation primitives were not error-checked
…des, code style fixes
…and make the benchmarked wait optional based on grb::Properties
…onal (only if needed), re-enable sleep (unrelated bugfix)
…it optional, and many code style fixes
…tional, remove one wait that should happen in the Pregel interface constructor but did not, and code style fixes
…g ALP primitives, check all wait error codes, and cody style improvements
…nchmark-loop optional, and check return code of all waits
…op conditional, error check all waits, code style fixes
anyzelman
approved these changes
Jul 8, 2025
Member
|
Full test suite started, with LPF, to make sure all changes here do not break anything. When confirmed they run OK, will merge. Thanks Aristeidis for contributing! |
Member
|
2467 tests pass, will merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding missing
grb::waitfor the correct benchmarking in multiple tests