Skip to content

363 missing grb wait for collecting execution times#364

Merged
anyzelman merged 31 commits intodevelopfrom
363-missing-grb-wait-for-collecting-execution-times
Jul 9, 2025
Merged

363 missing grb wait for collecting execution times#364
anyzelman merged 31 commits intodevelopfrom
363-missing-grb-wait-for-collecting-execution-times

Conversation

@aristeidis-mastoras
Copy link
Collaborator

adding missing grb::wait for the correct benchmarking in multiple tests

@anyzelman
Copy link
Member

anyzelman commented Jul 7, 2025

Concept release notes:

This MR adds calls to grb::wait for performance tests where its omission may result in false performance results for backends that perform nonblocking execution. This MR also fixes the following meta-bugs:

  • the return code of the label propagation algorithm was ignored in the performance benchmark driver,
  • same for the label propagation smoke test,
  • some initialisation operations were not error-checked in the BiCGstab smoke test,
  • same for the CG smoke tests,
  • re-enabled sleep(1) in the HPCG benchmark to detect system variabilities,
  • the Pregel API constructor did not account for nonblocking behaviour, and should wait before returning to adhere to RAII.

This MR also improves, on occasion, error reporting, and, as always, includes code style fixes. Thank you to @aristeidis-mastoras for flagging these issues and providing the initial fixes!

@anyzelman
Copy link
Member

Code review about 25% done (I thought this was an easy one, but alas...)

anyzelman added 14 commits July 8, 2025 10:57
…solve pre-existing bug where some error codes were not checked
…wait in the hot loop conditional (only if necessary), bugfix: some initialisation primitives were not error-checked
…and make the benchmarked wait optional based on grb::Properties
…onal (only if needed), re-enable sleep (unrelated bugfix)
anyzelman added 5 commits July 8, 2025 16:33
…tional, remove one wait that should happen in the Pregel interface constructor but did not, and code style fixes
…g ALP primitives, check all wait error codes, and cody style improvements
…nchmark-loop optional, and check return code of all waits
…op conditional, error check all waits, code style fixes
@anyzelman
Copy link
Member

Full test suite started, with LPF, to make sure all changes here do not break anything. When confirmed they run OK, will merge. Thanks Aristeidis for contributing!

@anyzelman
Copy link
Member

2467 tests pass, will merge

@anyzelman anyzelman merged commit 67af453 into develop Jul 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants