Resolve internal issue #495: fold from sparse vectors into scalars using monoids returns illegal#55

Merged

anyzelman merged 12 commits intodevelopfrom

495-fold-from-sparse-vectors-into-scalars-using-monoids-returns-illegal

Aug 18, 2022

Commits on Aug 17, 2022

Issue #495: start refactoring fold_from_vector_to_scalar_generic -- accept monoids and not (associative) operators
anyzelman
committed
Issue #495: refactoring fold_from_vector_to_scalar_generic: now that we assume monoid, we do not need the root-trick to cope with associative operators without identities. It also removes one previ…
anyzelman
committed
Bugfix: intermediate values should be of the output domain of the Monoid, not of the final output type.
anyzelman
committed
Code structure improvement and performance improvements for dense folds from vectors into scalars
anyzelman
committed
Output style fix
anyzelman
committed
Code structure improvement for general O(n) loop for folding vectors into scalars
anyzelman
committed
Performance bug resolved: all possibly-optimal variants implemented, as is a dispatcher. Corresponding unit test OK at this point.
anyzelman
committed
Issue #495: we now also test for fold-from-sparse-vector-into-scalars.
anyzelman
committed
Bugfixes (detected through improved unit test): did not catch trivial case of reducing vectors that hold no nonzeroes, and fix error in dispatching logic.
anyzelman
committed

Commits on Aug 18, 2022