Skip to content

Resolve internal issue #553: Allow for a tolerance in error checking in ALP gemm unit test #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Sep 30, 2022
Merged

Resolve internal issue #553: Allow for a tolerance in error checking in ALP gemm unit test #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/unit/alp_gemm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@

using namespace alp;

static double tol = 1.e-7;

/**
* Initializes matrix elements to random values between 0 and 1.
* Assumes the matrix uses full storage.
Expand Down Expand Up @@ -199,7 +201,7 @@ void alp_program( const size_t &unit, alp::RC &rc ) {
const auto calculated_value = alp::internal::access( C, alp::internal::getStorageIndex( C, i, j ) );

// Compare and report
if( expected_value != calculated_value ) {
if( std::abs( expected_value - calculated_value ) > tol ) {
#ifndef NDEBUG
std::cerr << "Numerically incorrect: "
"at (" << i << ", " << j << ") "
Expand Down