[Fix] Bugs where cleanup code is not executed correctly when bot exits #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bot exits, it sets
_should_exit(1), so thatBot._handle_should_exitwill be executed, which callscancel_scope.cancel()(2):This makes the finally block in
_run(3) not executed properly. According to my observation, the execution stops AFTER THE FIRSTawait.Added
with anyio.CancelScope(shield=True):line to fix this bug. It works on me.