Skip to content

Conversation

@cortesep
Copy link
Contributor

@cortesep cortesep commented Apr 4, 2023

No description provided.

@cortesep cortesep changed the title [WIP] ZDC - Introduction of RDH V7 ZDC - Introduction of RDH V7 Apr 4, 2023
Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cortesep

Please see comments below. Did you try to generate the raw data from the same MC with and w/o padding and make sure that the decoding results are the same?
Also, Pippo should have a FW with RDHv7 both with and w/o padding, perhaps you could ask for some real data to validate the decoding.

@cortesep cortesep changed the title ZDC - Introduction of RDH V7 [WIP] ZDC - Introduction of RDH V7 Apr 11, 2023
@cortesep cortesep changed the title [WIP] ZDC - Introduction of RDH V7 ZDC - Introduction of RDH V7 Apr 12, 2023
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 9cc6515 at 2023-04-12 19:17:

## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log:[ERROR] Workflow crashed - pid 32486 (gpu-reconstruction) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[32503:BadMapCalibSpec]: [17:07:44][ERROR] Insufficient statistics: 1 entries in lowE histo, do nothing
[ERROR] Workflow crashed - pid 32486 (gpu-reconstruction) was killed abnormally with exit code 128, could be out of memory killer, segfault, unhandled exception, SIGKILL, etc...
[ERROR] SEVERE: Device gpu-reconstruction (32486) returned with 128


## sw/BUILD/o2checkcode-latest/log
--
++ echo '========== List of errors found =========='
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/d04ac6c12d68634bf03e0030726d793d0f366945/slc8_x86-64/o2checkcode/1.0-local27/etc/modulefiles
++ cat
--

Full log here.

@cortesep
Copy link
Contributor Author

Stefan produced two files,
534496 DataFormat 0x0 :
Data rate 207 MBps, QC ON
RUN 534500 DataFormat 0x2 :
Data rate 138MBps, QC OFF

The ratio of data rates is 0.67 that is very close to 80/128=0.625
The checks on raw files with DumpRaw class and digigitzation followed by reconstruction do work smoothly.

@shahor02
Copy link
Collaborator

local fulCI passed, merging.

@shahor02 shahor02 merged commit 613bf8e into AliceO2Group:dev Apr 15, 2023
martenole pushed a commit that referenced this pull request Apr 18, 2023
* Propagate flag to select RDH version (#65)

* Introduce dataFormat = 2

* Fixes

* Fix in binning

* Please consider the following formatting changes (#66)

* Better error treatment

* Please consider the following formatting changes (#67)

* Avoid GBT word copy, use pointers

* Please consider the following formatting changes (#68)

---------

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
@cortesep cortesep deleted the fix_cdhv7_n branch April 28, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants