ITS-Study: create pt resolution, add efficiency of sec study #11763
Conversation
Roberta-Ferioli
requested review from
iouribelikov,
mconcas,
robincaron13 and
shahor02
as code owners
mconcas
changed the title
mconcas
left a comment
mconcas
left a comment
There was a problem hiding this comment.
Approving just for CI, do nt merge yet.
mconcas
changed the title
… clusters of secondary analysis
…start study on Pt resolution
…es on fake clusters and Pt resolution
mconcas
changed the title
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
|
Hi @TimoWilken, I see CentOS 8 builders failing the git fetch on multiple PRs. Will it run periodically so I can expect to have it going through at some point or shall I re-trigger the builds somehow? Thanks in advance. |
|
@mconcas @TimoWilken it's not clear to me how this could have passed the fullCI, given it breaks the code checker but apparently the test was green. Do we have some race condition in the tests? Was it force merged? |
|
Regression in code checker hopefully fixed by #12094. |
PR was merged with macos red as it always is lately, fullCI and co were green. Thanks for the fixes, I admittedly relied on automatic checks for this kind of problems. |
Yes, that's exactly my point. fullCI should have caught it already when checking the PR. |
…Group#11763) * create Ptresolution, add efficiency of sec study * Fix format * Add Pt res study at TrackChech * Add Pt resolution at check study * ITS-Study: add some study on efficiency of secondary tracks, add fake clusters of secondary analysis * fix formatting * fix formatting * ITS-Study: change structure, add Fake cluster study * ITS-Study:add fake clusters identification * [WIP] ITS-Study: completed study on fake clusters * ITS-Study:Completed the study on secondary tracks and fake clusters, start study on Pt resolution * ITS-Study: completed secondary tracks efficiency study, started studies on fake clusters and Pt resolution * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx --------- Co-authored-by: Matteo Concas <mconcas@cern.ch>
…Group#11763) * create Ptresolution, add efficiency of sec study * Fix format * Add Pt res study at TrackChech * Add Pt resolution at check study * ITS-Study: add some study on efficiency of secondary tracks, add fake clusters of secondary analysis * fix formatting * fix formatting * ITS-Study: change structure, add Fake cluster study * ITS-Study:add fake clusters identification * [WIP] ITS-Study: completed study on fake clusters * ITS-Study:Completed the study on secondary tracks and fake clusters, start study on Pt resolution * ITS-Study: completed secondary tracks efficiency study, started studies on fake clusters and Pt resolution * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx * Update Detectors/ITSMFT/ITS/postprocessing/studies/src/TrackCheck.cxx --------- Co-authored-by: Matteo Concas <mconcas@cern.ch>
4 participants
@mconcas