svertexer tuning #12270
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -301,6 +301,8 @@ void SVertexer::updateTimeDependentParams() | |
| for (auto& ft : mFitter3body) { | ||
| ft.setBz(bz); | ||
| } | ||
|
|
||
| mPIDresponse.setBetheBlochParams(mSVParams->mBBpars); | ||
| } | ||
|
|
||
| //______________________________________________ | ||
|
|
@@ -429,6 +431,7 @@ void SVertexer::buildT2V(const o2::globaltracking::RecoContainer& recoData) // a | |
| auto trackIndex = recoData.getPrimaryVertexMatchedTracks(); // Global ID's for associated tracks | ||
| auto vtxRefs = recoData.getPrimaryVertexMatchedTrackRefs(); // references from vertex to these track IDs | ||
| bool isTPCloaded = recoData.isTrackSourceLoaded(GIndex::TPC); | ||
| bool isITSloaded = recoData.isTrackSourceLoaded(GIndex::ITS); | ||
| if (isTPCloaded && !mSVParams->mExcludeTPCtracks) { | ||
| mTPCTracksArray = recoData.getTPCTracks(); | ||
| mTPCTrackClusIdx = recoData.getTPCTracksClusterRefs(); | ||
|
|
@@ -477,15 +480,32 @@ void SVertexer::buildT2V(const o2::globaltracking::RecoContainer& recoData) // a | |
| } | ||
| const auto& trc = recoData.getTrackParam(tvid); | ||
|
|
||
| bool hasTPC = false; | ||
| bool heavyIonisingParticle = false; | ||
| bool compatibleWithProton = mSVParams->mFractiondEdxforCascBaryons > 0.999f; // if 1 or above, accept all regardless of TPC | ||
| auto tpcGID = recoData.getTPCContributorGID(tvid); | ||
| if (tpcGID.isIndexSet() && isTPCloaded) { | ||
| hasTPC = true; | ||
| auto& tpcTrack = recoData.getTPCTrack(tpcGID); | ||
| float dEdxTPC = tpcTrack.getdEdx().dEdxTotTPC; | ||
| if (dEdxTPC > mSVParams->minTPCdEdx && trc.getP() > mSVParams->minMomTPCdEdx) // accept high dEdx tracks (He3, He4) | ||
| { | ||
| heavyIonisingParticle = true; | ||
| } | ||
| auto protonId = o2::track::PID::Proton; | ||
| float dEdxExpected = mPIDresponse.getExpectedSignal(tpcTrack, protonId); | ||
| float fracDevProton = std::abs((dEdxTPC - dEdxExpected) / dEdxExpected); | ||
| if (fracDevProton < mSVParams->mFractiondEdxforCascBaryons) { | ||
| compatibleWithProton = true; | ||
| } | ||
| } | ||
|
|
||
| // get Nclusters in the ITS if available | ||
| uint8_t nITSclu = -1; | ||
| auto itsGID = recoData.getITSContributorGID(tvid); | ||
| if (itsGID.getSource() == GIndex::ITS && isITSloaded) { | ||
| auto& itsTrack = recoData.getITSTrack(itsGID); | ||
| nITSclu = itsTrack.getNumberOfClusters(); | ||
| } | ||
|
|
||
| if (!acceptTrack(tvid, trc) && !heavyIonisingParticle) { | ||
|
|
@@ -494,9 +514,14 @@ void SVertexer::buildT2V(const o2::globaltracking::RecoContainer& recoData) // a | |
| } | ||
| continue; | ||
| } | ||
|
|
||
| if (!hasTPC && nITSclu < mSVParams->mITSSAminNclu) { | ||
| continue; // reject short ITS-only | ||
|
Collaborator
There was a problem hiding this comment. @ddobrigk why not doing this rejection at least configurable, to have a possibility to study the difference between 1 and 2?
Contributor
Author
There was a problem hiding this comment. @shahor02 what do you mean? If you set mITSSAminNclu to zero you don't cut on anything ;-)
Contributor
Author
There was a problem hiding this comment. @shahor02 what we could do if you like is to have an extra option to apply this solely to the cascade finding. It does seem like a bit of overkill to still keep very short and possibly very bad (in quality and especially p reso) ITS tracks, but if you want it, I can add an option, let me know. Thanks! :-D
Collaborator
There was a problem hiding this comment. I mean to have a possibility to reject short ITS-only tracks in cascades but to accept them in V0.
Collaborator
There was a problem hiding this comment.
Yes, this is what I meant. Even if we don't use this option, it is worth having it evaluate the eff. loss. |
||
| } | ||
|
|
||
| int posneg = trc.getSign() < 0 ? 1 : 0; | ||
| float r = std::sqrt(trc.getX() * trc.getX() + trc.getY() * trc.getY()); | ||
| mTracksPool[posneg].emplace_back(TrackCand{trc, tvid, {iv, iv}, r, hasTPC, nITSclu, compatibleWithProton}); | ||
| if (tvid.getSource() == GIndex::TPC) { // constrained TPC track? | ||
| correctTPCTrack(mTracksPool[posneg].back(), mTPCTracksArray[tvid], -1, -1); | ||
| } | ||
|
|
@@ -580,11 +605,15 @@ bool SVertexer::checkV0(const TrackCand& seedP, const TrackCand& seedN, int iP, | |
| } | ||
| // check tight lambda mass only | ||
| bool goodLamForCascade = false, goodALamForCascade = false; | ||
| bool usesTPCOnly = (seedP.hasTPC && seedP.nITSclu < 1) || (seedN.hasTPC && seedN.nITSclu < 1); | ||
| bool usesShortITSOnly = (!seedP.hasTPC && seedP.nITSclu < mSVParams->mITSSAminNcluCascades) || (!seedN.hasTPC && seedN.nITSclu < mSVParams->mITSSAminNcluCascades); | ||
| if (ptV0 > mSVParams->minPtV0FromCascade && (!mSVParams->mSkipTPCOnlyCascade || !usesTPCOnly) && !usesShortITSOnly) { | ||
| if (mV0Hyps[Lambda].checkTight(p2Pos, p2Neg, p2V0, ptV0) && (!mSVParams->mRequireTPCforCascBaryons || seedP.hasTPC) && seedP.compatibleProton) { | ||
| goodLamForCascade = true; | ||
| } | ||
| if (mV0Hyps[AntiLambda].checkTight(p2Pos, p2Neg, p2V0, ptV0) && (!mSVParams->mRequireTPCforCascBaryons || seedN.hasTPC && seedN.compatibleProton)) { | ||
| goodALamForCascade = true; | ||
| } | ||
| } | ||
|
|
||
| // apply mass selections for 3-body decay | ||
|
|
@@ -598,7 +627,7 @@ bool SVertexer::checkV0(const TrackCand& seedP, const TrackCand& seedN, int iP, | |
| } | ||
|
|
||
| // we want to reconstruct the 3 body decay of hypernuclei starting from the V0 of a proton and a pion (e.g. H3L->d + (p + pi-), or He4L->He3 + (p + pi-))) | ||
| bool checkFor3BodyDecays = mEnable3BodyDecays && (!mSVParams->checkV0Hypothesis || good3bodyV0Hyp) && (pt2V0 > 0.5) && (!mSVParams->mSkipTPCOnly3Body || !usesTPCOnly); | ||
| bool rejectAfter3BodyCheck = false; // To reject v0s which can be 3-body decay candidates but not cascade or v0 | ||
| bool checkForCascade = mEnableCascades && r2v0 < mMaxR2ToMeanVertexCascV0 && (!mSVParams->checkV0Hypothesis || (goodLamForCascade || goodALamForCascade)); | ||
| bool rejectIfNotCascade = false; | ||
|
|
@@ -746,6 +775,11 @@ int SVertexer::checkCascades(const V0Index& v0Idx, const V0& v0, float rv0, std: | |
| continue; // skip the track used by V0 | ||
| } | ||
| auto& bach = tracks[it]; | ||
|
|
||
| if (!bach.hasTPC && bach.nITSclu < mSVParams->mITSSAminNcluCascades) { | ||
| continue; // reject short ITS-only | ||
| } | ||
|
|
||
| if (bach.vBracket.getMin() > v0vlist.getMax()) { | ||
| LOG(debug) << "Skipping"; | ||
| break; // all other bachelor candidates will be also not compatible with this PV | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you wanted to avoid using these tracks in the cascades only. We don't have a problem with V0 finding timing and rejecting on this level may affect K0s efficiency.