Skip to content

Demote exit transition timeout error to warning #13036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 3 commits into from
Apr 23, 2024
Merged

Demote exit transition timeout error to warning #13036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1248045
Demote exit transition timeout error to warning
martenole Apr 17, 2024
2c591be
Fix
martenole Apr 17, 2024
d0e87d7
Format
martenole Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Framework/Core/src/DataProcessingDevice.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ void on_transition_requested_expired(uv_timer_t* handle)
auto* state = (DeviceState*)handle->data;
state->loopReason |= DeviceState::TIMER_EXPIRED;
O2_SIGNPOST_ID_FROM_POINTER(cid, device, handle);
O2_SIGNPOST_EVENT_EMIT_ERROR(device, cid, "callback", "Exit transition timer expired. Exiting.");
O2_SIGNPOST_EVENT_EMIT_WARN(device, cid, "callback", "Exit transition timer expired. Exiting.");
state->transitionHandling = TransitionHandlingState::Expired;
}

Expand Down
2 changes: 1 addition & 1 deletion Framework/Foundation/include/Framework/Signpost.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ void o2_debug_log_set_stacktrace(_o2_log_t* log, int stacktrace)
} else if (O2_BUILTIN_UNLIKELY(private_o2_log_##log->stacktrace)) { \
_o2_signpost_event_emit(private_o2_log_##log, id, name, remove_engineering_type(format).data(), ##__VA_ARGS__); \
} \
O2_RAW_LOG_RAW(warn, ##__VA_ARGS__); \
O2_LOG_MACRO_RAW(warn, format, ##__VA_ARGS__); \
})

#define O2_SIGNPOST_START(log, id, name, format, ...) \
Expand Down