-
Notifications
You must be signed in to change notification settings - Fork 483
CCDBApi: avoid leaking curl handle. #13061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Hi @ktf |
|
I frankly think the test is wrong, but indeed it needs understanding. @costing could you cc Michal? I do not recall his handle. |
|
Also the rest of the leak comes from the HTTPHEADER slist, however the way the code is currenlty structured, it's not easy to clean it up correctly. |
|
Adding @TrifleMichael |
|
Updated with the fix for the remaining leak. I think the delete in the test should not be there, but someone should probably doublecheck the logic. With this, my reproducer does not show any leak whatsoever. |
martenole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I don't understand why the formatting check fails
|
I think it's some glitch on the github side, actually. The code formats fine locally. |
CCDBApi: avoid leaking curl handle.