correct typo #18
Merged
correct typo #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahor02
referenced
this pull request
in shahor02/AliceO2
Jun 19, 2020
Not tested, it is Friday evening... Adding to compilation Not working yet, still using a struct for TOFChannelData, but with the boost histogram it seems too complicated. Now I will try using a class. I make the commit only to save the current version. Compiling TOFChannelData for now Adding TOFChannelCalibrator to compilation - but it fails adding destructors Fixes + updates Using 18 histograms Trying to make integral work - not successful for now misc fixes (#18) Co-authored-by: shahoian <ruben.shahoyan@cern.ch> Fixing integral function Leaving for now alternative methods, just for reference (they do not work as wanted anyway) Better integral functions. In the functions, there are still the three possibilities: 1) integral over reduced indexed loop (fastest); 2) integral over the complete indexed loop; 3) projection + accumulate (slowest). They are kept for reference for now, until the boost people find maybe a better way (see boostorg/histogram#277) Improve finalizeSlot Adding faster way to get the integral
shahor02
pushed a commit
that referenced
this pull request
Jun 22, 2020
Not tested, it is Friday evening... Adding to compilation Not working yet, still using a struct for TOFChannelData, but with the boost histogram it seems too complicated. Now I will try using a class. I make the commit only to save the current version. Compiling TOFChannelData for now Adding TOFChannelCalibrator to compilation - but it fails adding destructors Fixes + updates Using 18 histograms Trying to make integral work - not successful for now misc fixes (#18) Co-authored-by: shahoian <ruben.shahoyan@cern.ch> Fixing integral function Leaving for now alternative methods, just for reference (they do not work as wanted anyway) Better integral functions. In the functions, there are still the three possibilities: 1) integral over reduced indexed loop (fastest); 2) integral over the complete indexed loop; 3) projection + accumulate (slowest). They are kept for reference for now, until the boost people find maybe a better way (see boostorg/histogram#277) Improve finalizeSlot Adding faster way to get the integral
alibuild
pushed a commit
to alibuild/AliceO2
that referenced
this pull request
Nov 4, 2020
add event counter and tracing of empty crates in TOF decoding
davidrohr
pushed a commit
that referenced
this pull request
Jul 14, 2021
* Add CUDA backbone * HIP breaks * Make two separate libraries * Re-arrange directories * Add missing header * Meta library does not compile * Port hipInfo example to test gpu specs * Fix compilation to test build on EPN * Produce two separate executables * Flatten dir tree a bit * Cleanup * Add CMake forced re-configuration * HIP can't find symbols * Checkpoint before radical change * Create single executable * Update * Add first dummy benchmark * Assign a block to each scratch segment * Fix copyright * Please consider the following formatting changes (#16) * Set configurable iterations * Improve busy fucntion + streaming results on file * Fix bug in CLI params * Add configurable number of tests * Fix undefined behaviour insetting nLaunches * Please consider the following formatting changes (#17) * Streamline ker benchmarking w/ events * Tidy up kernels and improve output * Update read test * Please consider the following formatting changes (#18) * CP * Add last read test * Add last read test * Fix result dump on file * add reading kernel * Add write tests * Add copy benchmark * Remove CommonUtils dependency * Remove GPUCommon dependency * Fix fullCI errors * Revise result saving * Ready to test on EPN Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
* remove test folders add clang config * adding add library function in cmake
alibuild
pushed a commit
to alibuild/AliceO2
that referenced
this pull request
Oct 11, 2023
Please consider the following formatting changes to AliceO2Group#12044
alibuild
pushed a commit
to alibuild/AliceO2
that referenced
this pull request
Nov 17, 2023
Please consider the following formatting changes to AliceO2Group#12270
alibuild
pushed a commit
to alibuild/AliceO2
that referenced
this pull request
Mar 22, 2025
Please consider the following formatting changes to AliceO2Group#14069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct error caused by case insensitive MAC system!!!