Alice B-field derives from FairField + stores its parameters in MagFieldParam #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a generic container for the union of a char and a uint element of the same size. Simple definition of 1 to 8 byte decriptors. The generalization for more than 8 bytes can be activated later once an appropriate test setup is available.
matthiasrichter
requested changes
Feb 7, 2017
Collaborator
There was a problem hiding this comment.
This PR contains commits which have been already merged in PR #220 and #221. @shahor02 probably your branch is not correctly rebased to the dev.
The commits by @mkrzewic and @matthiasrichter have to be removed from the PR
What I actually do not understand is why github does not detect this. Maybe the duplicated commits can be dropped silently when merging fast forward. But if the normal git merge would be applied I'm sure we suddenly have the commits twice in the history.
|
|
||
| //__________________________________________________________________________________________________ | ||
| struct DataHeader; | ||
| struct DataIdentifier; |
Collaborator
Collaborator
Author
|
Thanks for spotting @matthiasrichter ! I just synced my dev to upstream/dev, but since I had already stuff pushed, it merged rather than doing FF, hope this is not a problem. |
Collaborator
Author
|
Closing this one, will open new PR |
knopers8
pushed a commit
to knopers8/AliceO2
that referenced
this pull request
Sep 7, 2020
- Get rid of all cout/cerr in QC framework in favour of QCInfoLogger - Introduce some of the changes I proposed in Qcinfologger to decrease verbosity, in particular ILOG(level) << xxx << ENDM
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
…liceO2Group#222) * PWGHF: make HfTagSelTracks handle Run 3 data with unassigned tracks * simplify * do no re-get vertex position for tracks from the same collision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @MohammadAlTurany, I've modified
Common/Field/MagneticFieldto derive from FairFieldto fill it params into MagFieldParam inheriting from FairParGenericSet, as we discussed privately.
Note that the
MagneticField::FillParContainer()looks for((FairRun*)fRun)->GetRuntimeDb()->getContainer("MagFieldParam")which it currently will not find, since current of instances of FairRun derive from Tutorial3 with hardcoded FairConstField / FairConstPar. Anyway, I understood you wanted implement yourself adding the field producer to the FairRun. I am wondering if we should not derive AliRun from FairRun, and set there all factories etc.In case you will need to create MagneticField factory, note that on top of its standard c-tor I've added
MagneticField(MagFieldParam& params).Question concerning
MagFieldParam::getParams(FairParamList* list)implementation: one of the parameters to store is text string, and the only method I found to retrieve it wasFairParamList::fill(const Text_t*,Text_t*,const Int_t), which leads to quite heavy construct to get the length of the string, see assignment of mMapPath inMagFieldParam::getParams. Is there an easier way of dealing with text (except storing TObjString?). Also, I think thisFairParamList::fill(const Text_t* name,Text_t* value,const Int_t length)method has a bug: it requires that the supplied length argument (i.e. the size of buffer for value) be> strlen(of_stored_string)-1, while to should be simply> strlen(of_stored_string)to allow for trailing \0.Cheers,
Ruben