Skip to content

Conversation

@dstocco
Copy link
Contributor

@dstocco dstocco commented May 4, 2017

In commit 3dc9c2e the aliceHLTWrapperApp executable was changed into aliceHLTWrapper.
However, this causes issues in non-case sensitive systems such as Mac OS X. Indeed, an aliceHLTWrapper.dir is created by cmake...and the system does not distinguish it from the aliceHLTwrapper.dir (notice the lower case for w) which comes from the Utilities/aliceHLTwrapper directory.
Switching back to the old name for the executable solves the issue

Copy link
Collaborator

@matthiasrichter matthiasrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't very happy about the previous change to aliceHLTWrapperApp since this broke a couple of other things. So I changed it back, not being aware of this problem on Mac OS. The change was hidden in a huge commit, so I could not understand the real reason.

I suggest to close this PR, I'm going to make a PR with consistent naming of the executables of the module.

@ktf @dberzano can the CI also be run on a mac os system? That would have detected the problem before the merge.

@ktf
Copy link
Member

ktf commented May 4, 2017

Shouldn't we rename / move / refactor Utilities/aliceHLTwrapper instead?

@dstocco
Copy link
Contributor Author

dstocco commented May 4, 2017

Hi @matthiasrichter ,
yes, sure: if you have a better idea on how to solve the issue, please go ahead.
I'm closing the pull request in the meanwhile.

Cheers,
Diego

@dstocco dstocco closed this May 4, 2017
@matthiasrichter matthiasrichter mentioned this pull request May 5, 2017
2 tasks
@dstocco dstocco deleted the hltWrapperExecName branch March 8, 2018 19:58
knopers8 pushed a commit to knopers8/AliceO2 that referenced this pull request Sep 7, 2020
1 per run (this is to keep the possibility to test backward compatibility)
mbroz84 pushed a commit to mbroz84/AliceO2 that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants