Protect TGeo material query by mutex and enable its usage in TRD tracking #4444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahor02
requested review from
davidrohr,
martenole and
sawenzel
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martenole @davidrohr the crash in mat. query in #4297 was because of multithreading: most of TGeometry operations are not thread-safe. I've protected TGeo calls by mutex and enabled material corrections in TRD, but for production benchmarks, we should only LUT (which is thread-safe) since the TGeo, apart from being extremely slow, with mutex may make the multithreading meaningless.