Skip to content

DPL: do not poll for configuration if there was none provided #5805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ktf merged 1 commit into from
Mar 30, 2021
Merged

DPL: do not poll for configuration if there was none provided #5805

ktf merged 1 commit into from
Mar 30, 2021

Conversation

@ktf
Copy link
Member

@ktf ktf commented Mar 26, 2021

No description provided.

@ktf ktf requested a review from a team as a code owner March 26, 2021 09:55
@ktf ktf force-pushed the do-not-hang-non-interactive branch from d4c667f to 5ab8326 Compare March 26, 2021 18:54
@ktf
DPL: improve configuration detection
55233b9 
Do not poll for configuration if we do not have a pipe or
a regular file.
@ktf ktf force-pushed the do-not-hang-non-interactive branch from 5ab8326 to 55233b9 Compare March 30, 2021 06:48
@ktf
Copy link
Member Author

ktf commented Mar 30, 2021

@sawenzel @davidrohr do you understand what is going on with:

Spawning hit merger on PID 59573; Redirect output to o2sim_mergerlog
[INFO] Merger process 59573 returned
[INFO] Simulation process took 0.96666 s
Error in <TFile::TFile>: file o2sim_Kine.root does not exist
[WARN] Kinematics file corrupted or does not exist
Job finished; Exiting 
PROCESS MAX MEM = 298.454

?

@davidrohr
Copy link
Collaborator

davidrohr commented Mar 30, 2021

do you understand what is going on with:

Not really yet, also this for some reason seems to affect only few PRs. I am currently running the full CI test in a docker locally, then I'll have a look at the result tomorrow.

@davidrohr
Copy link
Collaborator

davidrohr commented Mar 30, 2021

But you can ignore it for this PR certainly

@ktf ktf merged commit 6830856 into AliceO2Group:dev Mar 30, 2021
@ktf ktf deleted the do-not-hang-non-interactive branch March 30, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ktf @davidrohr