Add Armenteros-podolanski vars to str tables #5892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ddobrigk
commented
Apr 8, 2021
ddobrigk
commented
- adds armenteros-podolanski variables
- adds MGamma getter, some further useful things
- thanks to @dsekihat
iarsene
previously approved these changes
Apr 9, 2021
Collaborator
|
@ddobrigk The clang has to be fixed. |
aalkin
reviewed
Apr 9, 2021
|
|
||
| //Alpenteros-Podolanski variables | ||
| DECLARE_SOA_DYNAMIC_COLUMN(Alpha, alpha, [](float pxpos, float pypos, float pzpos, float pxneg, float pyneg, float pzneg) { | ||
| TVector3 momPos(pxpos, pypos, pzpos); |
Member
There was a problem hiding this comment.
Could you avoid using TVector3? While it is convenient, all those extra allocations will be considerably slow, if this dynamic column is called within a loop. It would be better to use plain calculation and add common parts as functions to RecoDecay header.
Contributor
Author
|
The latest commit gets rid of the TVector dependency... should be good to go now! Thanks again to @dsekihat :-D |
iarsene
approved these changes
Apr 13, 2021
cortesep
pushed a commit
to cortesep/AliceO2
that referenced
this pull request
Jun 11, 2021
* Add Armenteros-podolanski vars to str tables * Follow clang format rules * Update StrangenessTables.h
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
* Add Armenteros-podolanski vars to str tables * Follow clang format rules * Update StrangenessTables.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.