gammaTask first prototype #6034

sstiefel19 · 2021-04-30T15:21:41Z

before templating data/mc

Analysis/Tasks/PWGGA/myGammaTask3.cxx

jgrosseo · 2021-05-04T13:04:08Z

Analysis/Tasks/PWGGA/gammaConversionsMC.cxx

This has to be debug I guess

jgrosseo · 2021-05-04T13:04:44Z

Analysis/Tasks/PWGGA/gammaConversionsMC.cxx

please use LOGF

jgrosseo · 2021-05-04T13:05:12Z

Analysis/Tasks/PWGGA/gammaConversionsMC.cxx

Please change ATask to a meaningful name, and then you can drop the second argument (TaskName)

jgrosseo · 2021-05-04T13:05:40Z

Analysis/Tasks/PWGGA/gammaConversionsMC.h

Use meaningful help strings (third argument) for all configurables

jgrosseo · 2021-05-04T13:05:49Z

Analysis/Tasks/PWGGA/gammaConversionsMC.h

use LOGF everywhere

jgrosseo

Thanks for this first version. I have posted some comments, in addition to the ones of @iarsene

In addition: it is not needed to have an h and cxx file for the task. Put everything in the cxx file (as for the other analysis tasks).

github-actions · 2021-06-04T01:34:59Z

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

iarsene · 2021-06-05T12:36:09Z

@sstiefel19 Is there any update ? i received the 5 days warning before this PR will be automatically closed.

sstiefel19 · 2021-06-08T09:34:08Z

Hi @iarsene, @jgrosseo,
I reacted to the comments you had except to the one, that the PsiPair quantity should be added to the V0data table. This I will do now.

sstiefel19 · 2021-06-08T11:12:20Z

Analysis/Tasks/PWGGA/gammaConversionsMC.cxx

               aod::McParticles const& theMcParticles)
  {
    for (auto& lV0 : theV0s) {
      float lPhiV0Rec = static_cast<float>(M_PI) + std::atan2(-lV0.py(), -lV0.px());


just saw this quantity is also included in the V0s now. so I will take it from there with the next version

add a cut on found over findable tpc clusters update two tablenames

Analysis/Tasks/PWGGA/gammaConversionsMC.cxx

jgrosseo · 2021-06-21T07:10:13Z

Analysis/Tasks/PWGGA/gammaConversionsMC.cxx

+    {
+      {"IsPhotonSelected", "IsPhotonSelected", {HistType::kTH1F, {{12, -0.5f, 11.5f}}}},
+
+      {"beforeCuts/hPtRec_before", "hPtRec_before", {HistType::kTH1F, {{100, 0.0f, 25.0f}}}},


Why not skip _before here, you have them already in the folder "beforeCuts"?

I wanted to keep it in case I quickly plot its still directly visible what it is. But if wanted I can of course remove the _before, let me know

I meant to do: beforeCuts/hPtRec", "hPtRec_before
In this case it should be in the title, but not in the object name (but that one is always in the folder, so it is clear)

jgrosseo

See my two minor comments for consideration. I start the CI.

add cut on TPCCrossedRowsOverFindableCls add TPCFoundOverFindableCls to TracksExtra

remove _before in histo names

remove capital letters in executable name

sstiefel19 requested review from iarsene and jgrosseo as code owners April 30, 2021 15:21

iarsene reviewed May 3, 2021

View reviewed changes

Analysis/Tasks/PWGGA/myGammaTask3.cxx Outdated Show resolved Hide resolved

Analysis/Tasks/PWGGA/myGammaTask3.cxx Outdated Show resolved Hide resolved

sstiefel19 force-pushed the stephan_pushGammaTask branch from 4cc4182 to 867100c Compare May 3, 2021 17:04

jgrosseo reviewed May 4, 2021

View reviewed changes

Analysis/Tasks/PWGGA/gammaConversionsMC.cxx Outdated

Copy link

Collaborator

jgrosseo May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be debug I guess

jgrosseo reviewed May 4, 2021

View reviewed changes

Analysis/Tasks/PWGGA/gammaConversionsMC.cxx Outdated

Copy link

Collaborator

jgrosseo May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use LOGF

jgrosseo reviewed May 4, 2021

View reviewed changes

Analysis/Tasks/PWGGA/gammaConversionsMC.h Outdated

Copy link

Collaborator

jgrosseo May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use meaningful help strings (third argument) for all configurables

jgrosseo reviewed May 4, 2021

View reviewed changes

Analysis/Tasks/PWGGA/gammaConversionsMC.h Outdated

Copy link

Collaborator

jgrosseo May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use LOGF everywhere

jgrosseo requested changes May 4, 2021

View reviewed changes

github-actions bot added the stale label Jun 4, 2021

sstiefel19 force-pushed the stephan_pushGammaTask branch from 867100c to ce50fdc Compare June 8, 2021 09:05

sstiefel19 commented Jun 8, 2021

View reviewed changes

sstiefel19 force-pushed the stephan_pushGammaTask branch 2 times, most recently from a9a2c3a to dd8a934 Compare June 10, 2021 17:34

add gamma conversion task

424d6ce

sstiefel19 force-pushed the stephan_pushGammaTask branch from dd8a934 to 424d6ce Compare June 15, 2021 14:59

sstiefel19 requested a review from jgrosseo June 15, 2021 15:04

iarsene previously approved these changes Jun 16, 2021

View reviewed changes

PWGGA/gammaConversionsMC.cxx

d0fc51e

add a cut on found over findable tpc clusters update two tablenames

sstiefel19 dismissed iarsene’s stale review via d0fc51e June 18, 2021 15:56

jgrosseo reviewed Jun 21, 2021

View reviewed changes

Analysis/Tasks/PWGGA/gammaConversionsMC.cxx Outdated Show resolved Hide resolved

jgrosseo reviewed Jun 21, 2021

View reviewed changes

PWGGA/gammaConversionsMC

935dd67

add cut on TPCCrossedRowsOverFindableCls add TPCFoundOverFindableCls to TracksExtra

sstiefel19 requested a review from a team as a code owner June 22, 2021 17:07

jgrosseo previously approved these changes Jun 23, 2021

View reviewed changes

PWGGA/gammaConversionsMC.cxx

f33d22e

remove _before in histo names

sstiefel19 dismissed jgrosseo’s stale review via f33d22e June 23, 2021 15:26

jgrosseo previously approved these changes Jun 23, 2021

View reviewed changes

Update CMakeLists.txt

7ff3bf9

remove capital letters in executable name

sstiefel19 dismissed jgrosseo’s stale review via 7ff3bf9 June 24, 2021 09:15

jgrosseo approved these changes Jun 24, 2021

View reviewed changes

jgrosseo merged commit 072ede1 into AliceO2Group:dev Jun 25, 2021

mcoquet642 pushed a commit to mcoquet642/AliceO2 that referenced this pull request Jul 4, 2021

gammaTask first prototype (AliceO2Group#6034)

80103e4

EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021

gammaTask first prototype (AliceO2Group#6034)

d49db83

gammaTask first prototype #6034

gammaTask first prototype #6034

Uh oh!

Conversation

sstiefel19 commented Apr 30, 2021

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jgrosseo left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 4, 2021

Uh oh!

iarsene commented Jun 5, 2021

Uh oh!

sstiefel19 commented Jun 8, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jgrosseo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants