Muon chambers bitmap #6440
Muon chambers bitmap #6440
Conversation
| DECLARE_SOA_COLUMN(MatchScoreMCHMFT, matchScoreMCHMFT, float); //! MCH-MFT Machine Learning Matching Score for GlobalMuonTracks | ||
| DECLARE_SOA_COLUMN(MatchMFTTrackID, matchMFTTrackID, int); //! ID of matching MFT track for GlobalMuonTrack (ints while self indexing not available) | ||
| DECLARE_SOA_COLUMN(MatchMCHTrackID, matchMCHTrackID, int); //! ID of matching MCH track for GlobalMuonTracks (ints while self indexing not available) | ||
| DECLARE_SOA_COLUMN(MCHBitMap, MchBitMap, short); //! Fired muon chambers BitMap |
There was a problem hiding this comment.
Since you use it as a bit map, you should make this as unsigned, in this case uint16_t
|
Hi @nicolovalle, I had one comment on the type used for the bitmap column. Also, please fix the clang and space checker, both fail. |
Please consider the following formatting changes to #6440
|
This changes are good. Before merging, we have to adjust the RUN3 converter and produce new data. I convert this to draft, so that we do not merge it by accident. Could you take care of the changes? Once you have the PR in AliPhysics, mention this PR, so that we have the link. |
|
Hi, sorry, I forgot to paste the link. |
|
OK. I approved that one. Then we reproduce the data. |
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
|
@nicolovalle We forgot about this PR. Could you solve the conflict, so that we can merge it? |
4 participants
Bitmap with fired muon chambers added in StoredFwdTracks (Framework/Core/include/Framework/AnalysisDataModel.h) and ReducedMuonExtra table (Analysis/DataModel/include/AnalysisDataModel/ReducedInfoTables.h). PWDQQ table makers also extended.