Add first task of the LUT maker from fullsim #6498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
njacazio
commented
Jun 22, 2021
njacazio
commented
- Add single particle QA task
- Add 2D efficiency to efficiency QA task
- Add possibility to select charge depending on PDG code
Collaborator
Author
|
Input for the PR in AliceO2Group/DelphesO2#79 |
njacazio
force-pushed
the
nj-dev-lutmaker
branch
from
a2c384a to
28d9e00
Compare
Collaborator
Author
|
@ddobrigk here it is, what do you think? |
ktf
reviewed
Jun 22, 2021
njacazio
force-pushed
the
nj-dev-lutmaker
branch
from
28d9e00 to
64c6224
Compare
- Add single particle QA task - Add 2D efficiency to efficiency QA task - Add possibility to select charge depending on PDG code - Add Y for MC particles
njacazio
force-pushed
the
nj-dev-lutmaker
branch
from
64c6224 to
971a2f3
Compare
Collaborator
|
FullCI was waiting too long. Rest fine. Fingers crossed :) |
anerokhi
reviewed
Jul 25, 2021
Comment on lines
+201
to
+212
| if (noFakes) { // Selecting tracks with no fake hits | ||
| bool hasFake = false; | ||
| for (int i = 0; i < 10; i++) { // From ITS to TPC | ||
| if (track.mcMask() & 1 << i) { | ||
| hasFake = true; | ||
| break; | ||
| } | ||
| } | ||
| if (hasFake) { | ||
| continue; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Isn't this the same as just
if (noFakes and (track.mcMask() & 0b11'1111'1111)) { // Selecting tracks with no fake hits from ITS to TPC
continue;
}or you'll want to know the exact bit in the future?
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
- Add single particle QA task - Add 2D efficiency to efficiency QA task - Add possibility to select charge depending on PDG code - Add Y for MC particles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.