First step towards the simulation challenge

[victor-gonzalez]

For the time being is being a separate task
The final goal is a single one

Implemented

• data collection directly in differential form
• huge decrease in memory layout

[victor-gonzalez]

None of the four failed checks seem to have anything related with what I have done

[victor-gonzalez]

After today's WP4+WP14 meeting I've realized that the PR is big and perhaps I should have explained it a bit better.

The first commit basically replicates dptpdtcorrelations.cxx with two major changes in the DptDptCorrelationsTask which only involve variable definitions and their corresponding manipulations in the init and process methods.

The singles variables are indexed by track one and two and the pair variables are indexed by the four potential combinations. Few service functions were templated preparing the MC support. The main change is, apart that we simultaneously collect the four track combinations, that we do it directly in delta eta, delta phi. The gain in the memory and results file layouts is huge. This parallel the changes already introduced in the AliPhysics framework so that we will compare apples to apples when we run the benchmark.

The second commit just extracted the data collection out of the init and process methods encapsulating it into the DataCollectingEngine structure.

The third commit just removed the span of a task per centrality range and used instead a DataCollectingEngine per centrality range.

The fourth commit just changed the name of the task and of the source file to comply with the executable naming convention

The fifth commit just modified a sentence to comply with o2 code format

[iarsene]

Hi @victor-gonzalez,
The PR is in general fine with me. I just had a comment regarding the inline keywords.
Cheers,
Ionut

[victor-gonzalez]

You are right with the inline functions (https://isocpp.org/wiki/faq/inline-functions)
I will update the PR accordingly

[victor-gonzalez]

/sw/SOURCES/O2/6530-slc8_x86-64/0//Analysis/Tasks/PWGCF/dptdptcorrelations-simchl.cxx:1:1: error: missing or malformed copyright notice

Where can I find the right copyright notice?
The other errors seem to not be related with what I did

[victor-gonzalez]

@iarsene @jgrosseo any stopper for this PR?

[iarsene]

Hi Victor,
It is fine with me, but i don't know about the new "cs8" tests which are pending. I see they are pending for other PRs as well.
I will find out and see how to proceed.
Ionut

[victor-gonzalez]

@iarsene @jgrosseo @ktf macOS, o2 and o2-cs8 CI tests keep failing with reason not related to the changes I made

[jgrosseo]

Merging so that you can go ahead with your work.
What about using the histogram registry?
There is a typo in filteranalyistask