[O2-2424] DPL Analysis: Rework slicing algorithm for merged AODs #6557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalkin
changed the title
ktf
reviewed
Jun 30, 2021
Collaborator
|
Thanks @aalkin. This solves the problem indeed. |
sawenzel
previously approved these changes
Jul 1, 2021
…implifying the grouping
Member
Author
|
@ktf @sawenzel I've found even better solution - we do not, in fact, need to keep unassigned groups available for normal grouping operations. The slicing function will optionally fill and return those in a separate vector which may be needed later for different tasks. This also allows us to return to previous version of grouping that does not have any runtime checks. |
Collaborator
|
MacOS compilation checked locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves O2-2424