-
Notifications
You must be signed in to change notification settings - Fork 485
Fix some of the ALICE 3 geometry issues #6562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@afurs : A think your recent PR broke the MacOS builds. Could you please take a look and fix asap? |
|
@afurs : Thanks and no worries. |
|
Hi everyone, I am sorry to be pushy... but Bernhard and I would really like to have this merged soon so that we can run our strangeness tracking on batch farms. Would it be possible to merge this soon? Thank you very much! |
|
Hi David, all, Jochen already approved, so it is not clear to me where/why this is stuck. I don't think I can do much myself, I don't even have the option to approve as far as I can see... It may need a force-merge to clear the errors from the CI? |
|
Unfortunately github does not show PRs as an approved status when it's only partially approved, so it slipped my attention. |
Hi @sawenzel @qgp,
I just fixed some default values for the geometry of ALICE 3. I kindly need your approval and merge.
@rpezzi I am stll trying to do the fix for FT3 escavations in vacuum volume. Unfortunately tentatives so far failed for some yet unknown reason.
Difference with TRK is that I have to apply a transformation (z-translations) to the shapes of inner disk-holes and somehow this breaks the geometry streaming on file. For TRK it works because all the holes are centered in 0,0,0 and transformations are not required. I'll investigate a bit more on that.