A simple github action to check pragma once rule #6592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@TimoWilken : Could you please take a look if this looks reasonable? Eventually, we might make a combined action, encapsulating multiple of these simple checks. |
TimoWilken
suggested changes
Jul 6, 2021
Contributor
TimoWilken
left a comment
TimoWilken
left a comment
There was a problem hiding this comment.
Looks good, but I think you can remove a bunch of stuff to make this faster.
TimoWilken
approved these changes
Jul 6, 2021
Contributor
|
Thanks, merged. |
Collaborator
|
@sawenzel @TimoWilken It seem that this action is reporting unrelated files.
Also, there is no information in the log about what to do to fix the errors. |
Collaborator
Author
|
@vkucera : This happens when the PR is not rebased on dev (the developer has an old state). Feel free to improve the action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disallow
#pragma onceand check it with this github action.