Skip to content

Conversation

@ddobrigk
Copy link
Contributor

No description provided.

@ddobrigk
Copy link
Contributor Author

@a-mathis @jgrosseo here are the dynamic columns for the prong information. Please check for any obvious typos :-D Thanks!

@jgrosseo
Copy link
Collaborator

It does not seem to compile in the fullCI...

Copy link
Collaborator

@jgrosseo jgrosseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

@sartozza
Copy link
Contributor

@ddobrigk @jgrosseo may I ask you the status on this PR?
Just to know in case I need to update the V0 selection task.
Thanks!

@ddobrigk
Copy link
Contributor Author

@sartozza @jgrosseo documentation added, please check if more is needed!
...ah wait: my documentation fails clang-format... sigh. One moment.

@ddobrigk
Copy link
Contributor Author

Now fixed! Please let me know if further action is required :-D

@jgrosseo
Copy link
Collaborator

jgrosseo commented Jul 27, 2021

I fear yes...
mac is not happy
/System/Volumes/Data/build/ci_checks/alice_ci_0/o2/sw/SOURCES/O2/6690/0/Analysis/DataModel/include/AnalysisDataModel/StrangenessTables.h:158:52: error: no member named 'NegPx' in namespace 'o2::aod::v0data' v0data::NegativeEta<v0data::NegPx, v0data::NegPy, v0data::NegPz>, ~~~~~~~~^

@ddobrigk
Copy link
Contributor Author

@jgrosseo, we'll get there :-D Now my mac, at least, is happy!

Sorry for missing this mishap (I guess doing code in a beach city is by definition more error-prone, so I should probably avoid it :-D)

@ddobrigk
Copy link
Contributor Author

@jgrosseo the new error seems to be something I am innocent of... Can you please take a look? Thanks!

@jgrosseo jgrosseo merged commit 480b3bd into AliceO2Group:dev Jul 28, 2021
skundu692 pushed a commit to skundu692/AliceO2 that referenced this pull request Aug 10, 2021
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants