Minor fixes to get AliceO2 to build on Mac. #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise this causes an error when compiling on Mac with the latest xcode.
- Return 0 to avoid random result. - Assert in case code cannot / should not be reached.
ZMQ headers referred, but ZMQ not added to include path.
std:: is not really defined yet, so clang on mac actually complains about an implicitly defined namespace in the using statement.
Since 82XX there is only Pythia::init(). This mimicks the old, multi-argument Pythia::init(..).
knopers8
pushed a commit
to knopers8/AliceO2
that referenced
this pull request
Sep 7, 2020
* Removed unused classes and renamed many others * Move tobject2json to a subfolder
alibuild
added a commit
to alibuild/AliceO2
that referenced
this pull request
Jun 12, 2023
shahor02
pushed a commit
that referenced
this pull request
Jun 27, 2023
#11394) * Cleanup and fixes * Please consider the following formatting changes (#69) * Update noise model * Small updates * Please consider the following formatting changes (#70) * Resolve comments * Please consider the following formatting changes (#71) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Aug 24, 2023
AliceO2Group#11394) * Cleanup and fixes * Please consider the following formatting changes (AliceO2Group#69) * Update noise model * Small updates * Please consider the following formatting changes (AliceO2Group#70) * Resolve comments * Please consider the following formatting changes (AliceO2Group#71) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MohammadAlTurany: This is the forward port of #67.