Skip to content

Conversation

@davidrohr
Copy link
Contributor

@cuveland : This should adapt DD to new libfmt, which has removed make_format_args (https://github.com/fmtlib/fmt/pull/2760/files)

@cuveland
Copy link
Collaborator

cuveland commented Nov 2, 2022

@davidrohr Thanks for the fix! This works well.

To enable compile-time checking of the format string, the recommended way seems to be to use fmt::format_string<T...> as described in this post. That does require C++20 support, however, so I leave this as a comment here for a potential future improvement.

@cuveland cuveland merged commit 14c5744 into AliceO2Group:dev Nov 2, 2022
@davidrohr
Copy link
Contributor Author

@cuveland : thx, could you create a new minor tag with this fix?

@cuveland
Copy link
Collaborator

cuveland commented Nov 2, 2022

@davidrohr: done, see v1.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants