Skip to content

Conversation

@ktf
Copy link
Member

@ktf ktf commented Jun 11, 2025

  • Drop our own private copy of the headers
  • Use the CMake Config

- Drop our own private copy of the headers
- Use the CMake Config

***
@ktf
Copy link
Member Author

ktf commented Jun 11, 2025

@davidrohr as discussed in the meeting. This seems to compile fine.
@sawenzel any objections?

@davidrohr
Copy link
Collaborator

Looks good to me. However, in the past we also regularly needed to adapt the ClangTidyMain.cpp when the APIs changed. Not sure, has that stabilized now that it is a public API?

@ktf
Copy link
Member Author

ktf commented Jun 11, 2025

I do not know, I wouldn't be surprised if it was still unstable as an API. However it's not different from adapting to fair::mq / ROOT changes, no? I would tackle it as we do for other stuff, whenever clang gets updated.

@ktf ktf merged commit 38a6dad into master Jun 11, 2025
1 check passed
@ktf ktf deleted the pr44 branch June 11, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants