[PWGCF] Fixes and improvements for FemtoDream Cascades #3399
gmantzarAnnotations
2 errors, 10 warnings, and 1 notice
|
O2 linter result
Issues have been found.
|
|
O2 linter
Process completed with exit code 1.
|
|
[include-iostream]:
PWGCF/FemtoDream/Core/femtoDreamCascadeSelection.h#L25
Including iostream is discouraged. Use O2 logging instead.
|
|
[using-directive]:
PWGCF/FemtoDream/Core/femtoDreamCascadeSelection.h#L39
Using directives are not allowed in headers.
|
|
[external-pi]:
PWGCF/FemtoDream/Core/femtoDreamCascadeSelection.h#L411
Consider using the PI constant (and its multiples and fractions) defined in o2::constants::math.
|
|
[pi-multiple-fraction]:
PWGCF/FemtoDream/Core/femtoDreamCascadeSelection.h#L411
Consider using multiples/fractions of PI defined in o2::constants::math.
|
|
[pdg/database]:
PWGCF/FemtoDream/Core/femtoDreamCascadeSelection.h#L29
Direct use of TDatabasePDG is not allowed. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG>.
|
|
[const-ref-in-for-loop]:
PWGCF/FemtoDream/Core/femtoDreamCascadeSelection.h#L613
Use constant references for non-modified iterators in range-based for loops.
|
|
[name/function-variable]:
PWGCF/FemtoDream/Core/femtoDreamCascadeSelection.h#L316
Use lowerCamelCase for names of functions and variables.
|
|
[name/function-variable]:
PWGCF/FemtoDream/Core/femtoDreamCascadeSelection.h#L317
Use lowerCamelCase for names of functions and variables.
|
|
[name/function-variable]:
PWGCF/FemtoDream/Core/femtoDreamCascadeSelection.h#L318
Use lowerCamelCase for names of functions and variables.
|
|
[name/function-variable]:
PWGCF/FemtoDream/Core/femtoDreamCascadeSelection.h#L387
Use lowerCamelCase for names of functions and variables.
|
|
O2 linter
You can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test.
|