[PWGCF] Fixes and improvements for FemtoDream Cascades #9548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gmantzar
commented
Jan 27, 2025
gmantzar
commented
- Fixing selection bug in the Cascades
- Adding "BeforeCuts" and "AfterCuts" in the selection class of femtodream (for tracks and cascades only for now)
- chaning std::abs() to std::fabs() in the track and cascade selection
- adding the Omega selection flag in the producer task to select Omegas as Cascades
- Charge of the Cascade Candidates is determined by the cascade builder
- Adding "BeforeCuts" and "AfterCuts" in the selection class of femtodream (for tracks and cascades only for now) - chaning std::abs() to std::fabs() in the track and cascade selection - adding the Omega selection flag in the producer task to select Omegas as Cascades
…e charge in femtodream
gmantzar
requested review from
alibuild,
ariedel-cern,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
github-actions
bot
changed the title
| return false; | ||
| } | ||
| if (nEtaSel > 0 && std::abs(eta) > etaMax) { | ||
| if (nEtaSel > 0 && std::fabs(eta) > etaMax) { |
Collaborator
There was a problem hiding this comment.
std::abs is safe in case you wanted to keep it
victor-gonzalez
approved these changes
Jan 27, 2025
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
I approve it for the time being but the following linter recommendations need to be addressed in the next iteration
- the inclusion of
<iostream>, impact compilation time and should not be used in O2Physics - the use of
<TDatabasePDG.h>is quite inefficient regarding memory usage - use constant references for non-modified iterators in loops, that prevent inefficient memory management and access and also accidental inter-task common data modification which is really hard to catch
The rest of the linker recommendations needs to be addressed in a timely manner
And, please, remove all commented code, they reduce readability
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.