[PWGCF] Fix hEventCounter histogram#10404
Merged
victor-gonzalez merged 4 commits intoAliceO2Group:masterfrom Mar 8, 2025
Merged
[PWGCF] Fix hEventCounter histogram#10404victor-gonzalez merged 4 commits intoAliceO2Group:masterfrom
victor-gonzalez merged 4 commits intoAliceO2Group:masterfrom
Conversation
ilikmeta
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
ilikmeta
added a commit
to ilikmeta/O2Physics
that referenced
this pull request
Mar 8, 2025
[PWGCF] Please consider the following formatting changes to AliceO2Group#10404
Collaborator
|
Error while checking build/O2Physics/o2 for e0b12af at 2025-03-08 09:37: Full log here. |
Please consider the following formatting changes to AliceO2Group#10404
Contributor
Author
|
@victor-gonzalez Following your comments, I removed PDG_t:: prefix, no problems on the local test, but here Megalinter failed due to ITS PID leaks. Then, I put back the prefix, but still Megalinter fails. Not sure how to fix this. |
victor-gonzalez
approved these changes
Mar 8, 2025
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
MegaLinter error does not have anything to do with your PR
So you can safely remove the prefixes in the next iteration
louisemillot
pushed a commit
to louisemillot/O2Physics
that referenced
this pull request
Apr 8, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
njacazio
pushed a commit
that referenced
this pull request
Apr 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
EmilGorm
pushed a commit
to EmilGorm/O2Physics
that referenced
this pull request
Apr 15, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ariedel-cern
pushed a commit
to ariedel-cern/O2Physics
that referenced
this pull request
May 23, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply last comments (Thank you) and take out of doProcessData the EventCounter histogram.