[PWGDQ] Save the information of ambiguous pairs#10733
[PWGDQ] Save the information of ambiguous pairs#10733iarsene merged 17 commits intoAliceO2Group:masterfrom
Conversation
Please consider the following formatting changes to AliceO2Group#10733
|
Error while checking build/O2Physics/o2 for 8d48489 at 2025-04-02 16:24: Full log here. |
|
O2 linter results: ❌ 199 errors, |
Please consider the following formatting changes to AliceO2Group#10733
| std::map<int, std::vector<TString>> fMuonHistNames; | ||
| std::map<int, std::vector<TString>> fTrackMuonHistNames; | ||
| std::vector<AnalysisCompositeCut> fPairCuts; | ||
| std::vector<AnalysisCompositeCut> fTrackCuts; |
There was a problem hiding this comment.
Here you create a vector of composite cuts, but you actually just need the name of the cuts. So I suggest to make a vector of TString only.
| for (int icut = 0; icut < objArrayTrackCuts->GetEntries(); ++icut) { | ||
| fTrackCuts.push_back(*dqcuts::GetCompositeCut(objArrayTrackCuts->At(icut)->GetName())); | ||
| } |
There was a problem hiding this comment.
If you get the vector of cuts at this point, then this would mix-up the track bits and corresponding histogram directories. The problem is that these are the track cuts specified in the same event pairing configurable. This is not guaranteed to be in the same order (or they don't even exist in the track-selection task) as the cuts actually defined in the track selection task. As you see later in the init and the run function, for the track bits, we rely on the order in which the user provided the cuts in the track-selection task, not in this task. So I think its probably enough to actually initialize this vector a bit lower in the init function, where we loop over the track cuts defined in the track-selection task and check if these where required in the same-event-pairing task.
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Define histograms to save the information of mix event ambiguous pairs and also ambiguous pairs which are double counted for both same event and mix event.