[Common] Add histograms of TVX luminosity for RCT requirements#11323
Closed
fgrosa wants to merge 2 commits intoAliceO2Group:masterfrom
Closed
[Common] Add histograms of TVX luminosity for RCT requirements#11323fgrosa wants to merge 2 commits intoAliceO2Group:masterfrom
fgrosa wants to merge 2 commits intoAliceO2Group:masterfrom
Conversation
fgrosa
requested review from
a team,
alibuild,
ddobrigk,
ekryshen,
iarsene,
jgrosseo and
ktf
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
Collaborator
|
Hi @fgrosa, thanks for your efforts. Actually I am currently working on a similar functionality including pileup-up corrections and other features. In particular, I am going to isolate lumi task from bc selection task. I am going to commit my changes ~ today. So I would propose to close this PR. |
Collaborator
Author
Great, thanks a lot! I let this to you then :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ekryshen @aferrero2707 as discussed via email I added the histograms for the TVX counters / luminosity corresponding to the RCT selection flags. Could you please have a look? Thanks!