[PWGJE] Adding MC weights for JEJE injections, and adding mask for s… #11643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaff92
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 313 errors, |
github-actions
bot
changed the title
[PWGJE] Please consider the following formatting changes to AliceO2Group#11643
fjonasALICE
previously requested changes
Jun 17, 2025
| Configurable<bool> cfgGenHistograms{"cfgGenHistograms", false, "Enables Generated histograms"}; | ||
| Configurable<bool> cfgRecHistograms{"cfgRecHistograms", false, "Enables Reconstructed histograms"}; | ||
| Configurable<bool> cfgDataHistograms{"cfgDataHistograms", false, "Enables Data histograms"}; | ||
| Configurable<bool> cfgSkimmedTrigger{"cfgSkimmedTrigger", false, "Enables trigger for skimmied datasets (2023 onwards)"}; |
Collaborator
There was a problem hiding this comment.
I think this is not needed. If you do not provide any software trigger to your configurable cfgTriggerMasks, the function jetderiveddatautilities::selectTrigger will always evaluate TRUE (because there is. check in that function if the triggerMask is empty not. Please remove this configurable to avoid confusion
fjonasALICE
dismissed
their stale review
as this is time critical to obtain first output and it should not break anything, I agreed with Adrian that I approve for now as is and he will remove this configurable in a new PR tomorrow
fjonasALICE
approved these changes
Jun 17, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Jun 18, 2025
…AliceO2Group#11643) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jun 20, 2025
…AliceO2Group#11643) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Jul 16, 2025
…AliceO2Group#11643) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
…AliceO2Group#11643) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oftware triggers