[PWGHF] Fix Xic0 reconstruction online bug, add KF selection, new Xic0 task, and candidateCreator cleanup by Rrantu · Pull Request #11860 · AliceO2Group/O2Physics

Rrantu · 2025-07-01T12:39:50Z

In this PR, I fix an online application bug, add KF variable selection in candidateSelector, introduce a new Xic0 task file (taskXic0ToXiPiKf.cxx), and remove an unused variable and fix an existing bug in the KFParticle part ofcandidateCreator — including an incorrect ctau calculation, incorrect variable names and PDG codes in the cosThetaStar calculation, and a missing testBit check at the beginning.

…d new Xic0 task file

github-actions · 2025-07-01T12:40:05Z

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 2 disabled

alibuild · 2025-07-07T17:38:50Z

Error while checking build/O2Physics/o2 for f0e17df at 2025-07-07 19:38:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11860-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:1465:28: error: unused variable 'coordVtxCharmBaryon' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11860-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:1465:28: error: unused variable 'coordVtxCharmBaryon' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11860-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:1465:28: error: unused variable 'coordVtxCharmBaryon' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.


## sw/BUILD/ef0bfa363f0e36dbca43eafa7b9a4f237383317f-latest/log
/sw/SOURCES/O2Physics/11860-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:1465:28: error: unused variable 'coordVtxCharmBaryon' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11860-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:1465:28: error: unused variable 'coordVtxCharmBaryon' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/11860-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:1465:28: error: unused variable 'coordVtxCharmBaryon' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

Rrantu · 2025-07-08T07:27:34Z

Hi @fgrosa, I’ve updated the code. Could you please take a look and approve it?

PWGHF/D2H/Tasks/CMakeLists.txt

PWGHF/D2H/Tasks/taskXic0ToXiPi.cxx

vkucera · 2025-07-08T13:43:02Z

Please extend the PR description with an explanation of the bug that you fixed.

Rrantu · 2025-07-09T05:55:50Z

Please extend the PR description with an explanation of the bug that you fixed.

Thanks for the reminder! I’ve now extended the PR description with details about the bug I fixed earlier.

fgrosa · 2025-07-09T16:28:06Z

Hi @Rrantu please also fix the usage of tracks (propagated to the PV) and tracksIU (propagated at the innermost update) for charm baryon bachelor and Xi/Omega daughters instead (as discussed in #11764)

Please also wait that #11764 is merged before merging this one (I would expect quite some conflicts)

Thanks!

Hi @Rrantu please still fix the usage of the proper tracks (i.e. not propagated to the PV for the cascade daughters, and propagated to the PV for the bachelor) in the runKfXic0CreatorWithKFParticle function. I missed that in #11764 it was only partially done by @FDUEnrich, changing from the consumed table from Tracks to TracksIU, but Tracks should still be used for the charm bachelor. It would also be great if you could fix it also in the other functions that uses the KFParticle, i.e. runKfOmegac0CreatorWithKFParticle, runOmegac0Xic0ToOmegaKaCreatorWithKFParticle (since this is really a bug to be fixed). Thanks!

Rrantu · 2025-07-10T09:44:50Z

Hi @Rrantu please also fix the usage of tracks (propagated to the PV) and tracksIU (propagated at the innermost update) for charm baryon bachelor and Xi/Omega daughters instead (as discussed in #11764)
Please also wait that #11764 is merged before merging this one (I would expect quite some conflicts)
Thanks!

Hi @Rrantu please still fix the usage of the proper tracks (i.e. not propagated to the PV for the cascade daughters, and propagated to the PV for the bachelor) in the runKfXic0CreatorWithKFParticle function. I missed that in #11764 it was only partially done by @FDUEnrich, changing from the consumed table from Tracks to TracksIU, but Tracks should still be used for the charm bachelor. It would also be great if you could fix it also in the other functions that uses the KFParticle, i.e. runKfOmegac0CreatorWithKFParticle, runOmegac0Xic0ToOmegaKaCreatorWithKFParticle (since this is really a bug to be fixed). Thanks!

Hi @fgrosa, I’ve fixed the usage of the proper tracks — cascade daughters now use TracksIU, and the charm bachelor uses Tracks, as expected. Let me know if anything still looks off.

fgrosa · 2025-07-10T13:00:04Z

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

+      auto trackCascDauCharged = casc.bachelor_as<MyKfTracksIU>(); // pion <- xi track
+      auto trackV0Dau0 = casc.posTrack_as<MyKfTracksIU>();         // V0 positive daughter track
+      auto trackV0Dau1 = casc.negTrack_as<MyKfTracksIU>();         // V0 negative daughter track


Casting with _as<> will raise a runtime error, since the Tracks and TracksIU tables have the same index. You need to access the track tables "by hand" with rawIteratorAt, as done in the process functions for the DCAFitter, see e.g.

O2Physics/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

Lines 476 to 478 in 2d0c61b

auto trackCascDauCharged = lfTracks.rawIteratorAt(trackCascDauChargedId); // pion <- xi track

auto trackV0Dau0 = lfTracks.rawIteratorAt(trackV0Dau0Id); // V0 positive daughter track

auto trackV0Dau1 = lfTracks.rawIteratorAt(trackV0Dau1Id); // V0 negative daughter track

Thank you! I’ve updated the code to use rawIteratorAt() instead of _as<>.

…0 task, and candidateCreator cleanup (AliceO2Group#11860)

Rrantu added 13 commits June 10, 2025 15:24

Add Xic0 flow task and fix O2 linter issues

f119bf9

Set the switch back to true

177a5bf

Fix MegaLinter issues

cd3661c

Change ampl to const reference

1f2465d

Pass ampl by value

9b24c7c

Add author

bf7cede

fix error

e4a662a

fix error

5356768

Merge branch 'master' of https://github.com/AliceO2Group/O2Physics

303001d

reduce creator memory consumption, fix online application bug, and ad…

ffd32e4

…d new Xic0 task file

fix CmakeLists format

0c163f7

delete selectionResult variable

3f08607

fix errors

6f16c85

github-actions bot added pwghf PWG-HF datamodel labels Jul 1, 2025

github-actions bot changed the title ~~Fix Xic0 reconstruction online bug, add KF selection, new Xic0 task, and candidateCreator cleanup~~ [PWGHF] Fix Xic0 reconstruction online bug, add KF selection, new Xic0 task, and candidateCreator cleanup Jul 1, 2025

Rrantu marked this pull request as ready for review July 1, 2025 12:56

Rrantu requested review from NicoleBastid, alibuild, apalasciano, deepathoms, fcatalan92, fcolamar, fgrosa, hahassan7, jpxrk, mfaggin, mmazzilli and vkucera as code owners July 1, 2025 12:56

update as comment and fix error

2f9b186

vkucera marked this pull request as draft July 7, 2025 14:21

fix O2 linter error

71d2402

Rrantu marked this pull request as ready for review July 8, 2025 04:28

Rrantu requested review from fgrosa, vkucera and zhangbiao-phy July 8, 2025 05:54

vkucera requested changes Jul 8, 2025

View reviewed changes

PWGHF/D2H/Tasks/CMakeLists.txt Outdated Show resolved Hide resolved

PWGHF/D2H/Tasks/taskXic0ToXiPi.cxx Outdated Show resolved Hide resolved

PWGHF/D2H/Tasks/taskXic0ToXiPi.cxx Outdated Show resolved Hide resolved

vkucera marked this pull request as draft July 8, 2025 13:11

Update based on the comment

e9fc2f6

Rrantu marked this pull request as ready for review July 8, 2025 13:32

vkucera previously approved these changes Jul 9, 2025

View reviewed changes

fix the usage of tracks

5b3c2cd

Rrantu dismissed vkucera’s stale review via 5b3c2cd July 10, 2025 09:32

fgrosa reviewed Jul 10, 2025

View reviewed changes

update the code

07c8046

fgrosa approved these changes Jul 11, 2025

View reviewed changes

fgrosa merged commit 148b2ec into AliceO2Group:master Jul 11, 2025
12 of 14 checks passed

jpxrk pushed a commit to jpxrk/O2Physics that referenced this pull request Jul 16, 2025

[PWGHF] Fix Xic0 reconstruction online bug, add KF selection, new Xic…

1e80468

…0 task, and candidateCreator cleanup (AliceO2Group#11860)

prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jul 18, 2025

[PWGHF] Fix Xic0 reconstruction online bug, add KF selection, new Xic…

3e65a04

…0 task, and candidateCreator cleanup (AliceO2Group#11860)

JimunLee pushed a commit to JimunLee/O2Physics that referenced this pull request Jul 22, 2025

[PWGHF] Fix Xic0 reconstruction online bug, add KF selection, new Xic…

06c3aef

…0 task, and candidateCreator cleanup (AliceO2Group#11860)

vojmach pushed a commit to vojmach/O2Physics that referenced this pull request Jul 23, 2025

[PWGHF] Fix Xic0 reconstruction online bug, add KF selection, new Xic…

fcaf9fa

…0 task, and candidateCreator cleanup (AliceO2Group#11860)

jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025

[PWGHF] Fix Xic0 reconstruction online bug, add KF selection, new Xic…

2981091

…0 task, and candidateCreator cleanup (AliceO2Group#11860)

alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Dec 5, 2025

[PWGHF] Fix Xic0 reconstruction online bug, add KF selection, new Xic…

06f907f

…0 task, and candidateCreator cleanup (AliceO2Group#11860)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PWGHF] Fix Xic0 reconstruction online bug, add KF selection, new Xic0 task, and candidateCreator cleanup#11860

[PWGHF] Fix Xic0 reconstruction online bug, add KF selection, new Xic0 task, and candidateCreator cleanup#11860
fgrosa merged 23 commits intoAliceO2Group:masterfrom
Rrantu:master

Rrantu commented Jul 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 1, 2025 •

edited

Loading

Uh oh!

alibuild commented Jul 7, 2025

Uh oh!

Rrantu commented Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera commented Jul 8, 2025

Uh oh!

Rrantu commented Jul 9, 2025

Uh oh!

fgrosa commented Jul 9, 2025

Uh oh!

Rrantu commented Jul 10, 2025

Uh oh!

fgrosa Jul 10, 2025

Uh oh!

Rrantu Jul 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

	auto trackCascDauCharged = lfTracks.rawIteratorAt(trackCascDauChargedId); // pion <- xi track
	auto trackV0Dau0 = lfTracks.rawIteratorAt(trackV0Dau0Id); // V0 positive daughter track
	auto trackV0Dau1 = lfTracks.rawIteratorAt(trackV0Dau1Id); // V0 negative daughter track

Conversation

Rrantu commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Jul 7, 2025

Uh oh!

Rrantu commented Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera commented Jul 8, 2025

Uh oh!

Rrantu commented Jul 9, 2025

Uh oh!

fgrosa commented Jul 9, 2025

Uh oh!

Rrantu commented Jul 10, 2025

Uh oh!

fgrosa Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Rrantu Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

Rrantu commented Jul 1, 2025 •

edited

Loading

github-actions bot commented Jul 1, 2025 •

edited

Loading