Skip to content

Add new default function with Run 3 ITS requirements.#1234

Merged
jgrosseo merged 3 commits intoAliceO2Group:masterfrom
mfaggin:updateDefITSmatch
Sep 13, 2022
Merged

Add new default function with Run 3 ITS requirements.#1234
jgrosseo merged 3 commits intoAliceO2Group:masterfrom
mfaggin:updateDefITSmatch

Conversation

@mfaggin
Copy link
Collaborator

@mfaggin mfaggin commented Sep 12, 2022

No description provided.

@mfaggin
Copy link
Collaborator Author

mfaggin commented Sep 12, 2022

This PR is meant to propose global track selections overcoming the actual default requirement on the ITS matching, which is a refuse from the Run 2 SPD. The proposed solution requires to change a Configurable in the trackselection.cxx workflow (ie: in hyperloop a different core Service wagon for each possible configuration, potentially), however it seems to me quite smart and transparent for the users, since they do not need to touch at all their analysis code. Let me know what you think.

@jgrosseo
Copy link
Contributor

jgrosseo commented Sep 12, 2022

This looks good to me.

Just one comment: why the "k" in the middle of the enum word. E.g. Run3ITSIBkAny ? The "k" was a prefix value for enums in the past (for constant) but as a first character (not needed by today's coding conventions anymore) and I don't think it is needed in the middle of the words. ;-)

@mfaggin
Copy link
Collaborator Author

mfaggin commented Sep 13, 2022

This looks good to me.

Just one comment: why the "k" in the middle of the enum word. E.g. Run3ITSIBkAny ? The "k" was a prefix value for enums in the past (for constant) but as a first character (not needed by today's coding conventions anymore) and I don't think it is needed in the middle of the words. ;-)

Thanks @jgrosseo , I followed your suggestions (my bad, I always refer to kAny when talking about this kind of selections), let me know if this is fine for you

@jgrosseo
Copy link
Contributor

For me this looks good. Do others have comments?
I think after this is merged, you can announce it and then we can put the default also to a Run 3 (instead of Run 2). @ddobrigk what do you think?

@mfaggin
Copy link
Collaborator Author

mfaggin commented Sep 13, 2022

For me this looks good. Do others have comments? I think after this is merged, you can announce it and then we can put the default also to a Run 3 (instead of Run 2). @ddobrigk what do you think?

Before doing the announcement, I can also update the instructions in the documentation (here: https://aliceo2group.github.io/analysis-framework/docs/helperTasks/trackselection.html) below the table with the track selections

@jgrosseo jgrosseo merged commit 7a18aef into AliceO2Group:master Sep 13, 2022
ctolon added a commit to ctolon/PythonInterfaceOOP that referenced this pull request Sep 13, 2022
* fix typo in helper message for table-maker interface

* v0selector helper message update for d_bz_input

* trackselection interface integration ((AliceO2Group/O2Physics#1234))

* version bumped to nightly-20220914
@mfaggin mfaggin deleted the updateDefITSmatch branch September 14, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants