[PWGCF] - FemtoDream: Implementing phi and K* particles in FemtoDream #12655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified/ added new files for particle reconstruction via the inv mass due to short life time. Selection is implemented in the ResoSelection header. For this new types in femtoDreived.h were implemented. The Producer task was changed to reconstruct the phi and filltables. In order to get pid-cuts for further partitioning(inside debug-reso and pair-task) the cutculator was modified.
the pair task for v0-resonance has now close-pair rejection. For this femtoDreamDetaDphiStar.h was changed. A histogram was added in femtoDreamContainer.hin order to get data for purity and sideband analysis.
Changed femtoDreamV0Selection.h to also select K0Short. Added header femtoDreamResoSelection.h to select KStar. Changged ProducerTask to activate and do the Reso-selection.
I dont think it could build before, it now does.
gmantzar
requested review from
alibuild,
ariedel-cern,
glromane,
jgrosseo,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
github-actions
bot
changed the title
|
O2 linter results: ❌ 860 errors, |
gmantzar
changed the title
Please consider the following formatting changes to AliceO2Group#12655
PWGCF/DataModel/FemtoDerived.h
Outdated
Comment on lines
96
to
107
| kTrack, //! Track | ||
| kV0, //! V0 | ||
| kReso, //! Resonances (phi) | ||
| kResoChild, // Child track of a Resonance | ||
| kV0Child, //! Child track of a V0 | ||
| kPhiPosdaughTPC_NegdaughTPC, /// cases for Phi-daughters for TPC or TOF combinations | ||
| kPhiPosdaughTPC_NegdaughTOF, | ||
| kPhiPosdaughTOF_NegdaughTPC, | ||
| kPhiPosdaughTOF_NegdaughTOF, | ||
| kCascade, //! Cascade | ||
| kCascadeV0, | ||
| kCascadeV0Child, |
Collaborator
There was a problem hiding this comment.
If this goes to the derived data the new version will not be backward compatible with the already produced derived data.
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please, have a look at my comment
Also, please, be sure that all the new source files adhere to the linter an MegaLinter recommendations
added 3 commits
August 22, 2025 12:46
The partitions for particle selection in pair-task and debug-task were changed due to change in the way of how FDParticles is filled inside the producer task. The task was renamed and no longer needed files are removed.
Updated producer task and necessary header.
Collaborator
|
Please, keep it as draft until it gets ready for not using central CI resources |
Contributor
Author
|
Closing PR so that @nils Konert and @christopher Klumm can take over with the Linter checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified/ added new files for particle reconstruction via the inv mass due to short life time. Selection is implemented in the ResoSelection header. For this new types in femtoDreived.h were implemented.
The Producer task was changed to reconstruct the phi and filltables. In order to get pid-cuts for further partitioning(inside debug-reso and pair-task) the cutculator was modified.
The changes where adapted to select also K* resonances.
For testing purposes, two new producer tasks were created in order not not interfere with the other tasks. They will be merged once the correct functionality is validated.