Change type Run2 trigger aliaslabels#1350
Merged
iarsene merged 3 commits intoAliceO2Group:masterfrom Oct 13, 2022
Merged
Conversation
Collaborator
|
Fine with me to change char* to std::string |
Collaborator
|
I noticed that you fill the primary vertex histograms only in the |
jgrosseo
previously approved these changes
Oct 12, 2022
vkucera
requested changes
Oct 12, 2022
jgrosseo
approved these changes
Oct 12, 2022
Collaborator
Author
iarsene
approved these changes
Oct 13, 2022
GijsvWeelden
pushed a commit
to GijsvWeelden/O2Physics
that referenced
this pull request
Jan 13, 2023
* Change type trigger aliaslabels from char to string * fix trigger selection HF, add few validation hists * fill PV histogram also in processNoTrigSel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change of type
aliasLabelsfromconst char*tostd::stringis required to use it as a lookup table to find the corresponding enum value from a configurable string (which is the strategy in HF).To me this looks as a trivial change, but maybe I'm missing something why it should be a
char*array? @ekryshen @jgrosseo ?If it should remain a
char*array, we should think of a better strategy to do the trigger selection in HF, since right now events are selected based on the condition that the next event has a kINT7 trigger enabled (independent of what trigger you set in the json file). @vkucera