Skip to content

Fix for Mac not accepting not override marked overriding methods#1351

Merged
victor-gonzalez merged 2 commits intoAliceO2Group:masterfrom
victor-gonzalez:master
Oct 12, 2022
Merged

Fix for Mac not accepting not override marked overriding methods#1351
victor-gonzalez merged 2 commits intoAliceO2Group:masterfrom
victor-gonzalez:master

Conversation

@victor-gonzalez
Copy link
Collaborator

No description provided.

alibuild
alibuild previously approved these changes Oct 12, 2022
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @victor-gonzalez.

@jgrosseo jgrosseo disabled auto-merge October 12, 2022 10:49
@jgrosseo
Copy link
Contributor

I disabled the auto merge because in this way you can see the macos CI output

@victor-gonzalez
Copy link
Collaborator Author

Thanks!

@victor-gonzalez
Copy link
Collaborator Author

This one is a bit strange because I thought uint64_t was an unsigned long
I will try the suggested format and see if it goes through Ubuntu

@victor-gonzalez
Copy link
Collaborator Author

@jgrosseo So with the suggested formatting from the Mac compiler Ubuntu gives this warning

/localone/alice/O2Physics/PWGCF/TwoParticleCorrelations/Core/SelectionFilterAndAnalysis.cxx:63:37: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=]
   63 |     str += TString::Format("0x%016llx", option);
      |                               ~~~~~~^   ~~~~~~
      |                                     |   |
      |                                     |   long unsigned int
      |                                     long long unsigned int
      |                               %016lx

and suggests the opposite to Mac
Any suggestion?

@victor-gonzalez
Copy link
Collaborator Author

victor-gonzalez commented Oct 12, 2022

Will an explicit cast u_long(option) work in Mac?
Leaving the previous format

@jgrosseo
Copy link
Contributor

@victor-gonzalez
Copy link
Collaborator Author

But I guess the issue happens when requiring the hexadecimal x format

Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @victor-gonzalez.

@victor-gonzalez victor-gonzalez merged commit 074bf0b into AliceO2Group:master Oct 12, 2022
GijsvWeelden pushed a commit to GijsvWeelden/O2Physics that referenced this pull request Jan 13, 2023
…ceO2Group#1351)

* Fix for Mac not accepting not override marked overriding methods

* Update SelectionFilterAndAnalysis.cxx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants