[Common] mean-pt shape selection tables#13664
Conversation
|
O2 linter results: ❌ 0 errors, |
|
@ddobrigk Hi David, can you have a look here when you have time? I tag also @victor-gonzalez for a review. I put a comment in the top of what is added. I will present in the correlations PAG next week. Hopefully it can be merged, so I can use the tables in the ese analysis and I can run it on some more data before then! Cheers, |
joachimckh
requested review from
a team,
alibuild,
ddobrigk,
iarsene,
jgrosseo and
ktf
as code owners
| if (first) { | ||
| auto tp = reinterpret_cast<TProfile*>(tar->FindObject("pMeanPt")); | ||
| if (!tp) { | ||
| tar->Add(new TProfile("pMeanPt", "", centBin, 0, centBin)); | ||
| tp = reinterpret_cast<TProfile*>(tar->At(tar->GetEntries() - 1)); | ||
| } | ||
| tp->Fill(centrality, pt); | ||
| } else { | ||
| auto th2 = reinterpret_cast<TH2D*>(tar->FindObject("hPtWeight")); | ||
| if (!th2) { | ||
| tar->Add(new TH2D("hPtWeight", "", centBin, 0, centBin, ptBin, ptAxis->GetXmin(), ptAxis->GetXmax())); | ||
| th2 = reinterpret_cast<TH2D*>(tar->At(tar->GetEntries() - 1)); | ||
| } | ||
| th2->Fill(centrality, pt); | ||
| } |
There was a problem hiding this comment.
Is it actually needed to have a FindObject which involves string comparison (char by char) on a per track level?
There was a problem hiding this comment.
Hi @victor-gonzalez,
I have created pointers for this, and only assign them once for the pT objects as they remain static.
Common/Core/FFitWeights.cxx
Outdated
| // printf("qh not found!\n"); | ||
| // LOGF(info, "FFitWeights qh not found!"); |
There was a problem hiding this comment.
Don't leave code commented
There was a problem hiding this comment.
I have removed the printf and added LOGF and generally removed outcommented lines in the code.
|
@victor-gonzalez Do you have more comments? Otherwise I will ping David :) |
3 participants
Added tables for calculating mean-pT shape selection in light ions. Table contains value between 0-99 reflecting the quantile of the global mean-pT ensemble.