[Trigger,PWGHF] Added trigger for Sc-proton correlation#14786
[Trigger,PWGHF] Added trigger for Sc-proton correlation#14786singhra1994 wants to merge 23 commits intoAliceO2Group:masterfrom
Conversation
Added parameters for Sigma_C trigger selection and updated event tagging logic for SigmaC candidates.
Added support for SigmaC particle selection in the HfFilterHelper class.
singhra1994
requested review from
alibuild,
ariedel-cern,
fgrosa,
lietava,
mpuccio and
zhangbiao-phy
as code owners
[Trigger,PWGHF] Please consider the following formatting changes to AliceO2Group#14786
fgrosa
left a comment
fgrosa
left a comment
There was a problem hiding this comment.
Hi @singhra1994 I still didn't look into the helper functions, but I already spotted several issues in the logic of the filter itself. Please implement the suggestions, and then I will take a look at the helper functions as well.
[Trigger,PWGHF] Please consider the following formatting changes to AliceO2Group#14786
fgrosa
left a comment
fgrosa
left a comment
There was a problem hiding this comment.
Hi @singhra1994, thanks for addressing my comments! The code looks correct to me now, but I would like to ask @mfaggin also to check that I didn't overlook any other bug that might affect the SigmaC-K triggers.
Please also address my remaining comments and then as discussed in the trigger meeting, verify that the output of the task is identical for the other triggers before and after your changes, so that we can then merge it. Thanks!
EventFiltering/PWGHF/HFFilter.cxx
Outdated
|
|
||
| // array of BDT thresholds | ||
| std::array<LabeledArray<double>, kNCharmParticles> thresholdBDTScores; | ||
| std::array<LabeledArray<double>, kNCharmParticles + 1> thresholdBDTScores; |
There was a problem hiding this comment.
I agree with this comment: leave your BDT fully independent from the others which are general for the triggers.
mfaggin
left a comment
mfaggin
left a comment
There was a problem hiding this comment.
Hi @fgrosa @singhra1994 I tried to go through the modifications and I posted some comments. It looks to me that the already existing trigger Sc-K is not affected by the proposed modifications, but I have a couple of warnings/comments for the Sc-p part.
EventFiltering/PWGHF/HFFilter.cxx
Outdated
|
|
||
| // array of BDT thresholds | ||
| std::array<LabeledArray<double>, kNCharmParticles> thresholdBDTScores; | ||
| std::array<LabeledArray<double>, kNCharmParticles + 1> thresholdBDTScores; |
There was a problem hiding this comment.
I agree with this comment: leave your BDT fully independent from the others which are general for the triggers.
Updated PID cuts and added new parameters for SigmaC-pr correlation. Adjusted track selection criteria and improved comments for clarity.
[Trigger,PWGHF] Please consider the following formatting changes to AliceO2Group#14786
EventFiltering/PWGHF/HFFilter.cxx
Outdated
| } | ||
| float deltaEta = std::abs(RecoDecay::eta(pVecSigmaC) - track.eta()); | ||
| if (!keepEvent[kSigmaCPr] && (isTrackProton && deltaEta < 1.0)) { | ||
| auto tagBDT = helper.isBDTSelected(scores[2], thresholdBDTScoreScLcToPiKP.value); |
There was a problem hiding this comment.
Move this cut as suggested in the previous round of review
There was a problem hiding this comment.
With this comment I was suggesting to move the cuts on the BDT scores in the configurable with cuts for the SigmaCPr trigger, i.e. cutsSigmaCPr. Once done the PR looks good to me and when properly tested we can merge it.
Updated configurable parameters for SigmaCPr trigger and added logic for SigmaC-proton correlation. Enhanced event tagging and BDT score handling for SigmaC candidates.
[Trigger,PWGHF] Please consider the following formatting changes to AliceO2Group#14786
fgrosa
changed the title
Refactor function call to improve readability by moving comment to the same line as the parameter.
4 participants
I have modified the block trigger SigmaCPPK in such a way that both SigmaCPPK and SigmaCP can be filled in the same block