Skip to content

Propagatorqa added for performance optimisations #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddobrigk merged 9 commits into from
Dec 4, 2022
Merged

Propagatorqa added for performance optimisations #1581

ddobrigk merged 9 commits into from
Dec 4, 2022

Conversation

@ddobrigk
Copy link
Collaborator

@ddobrigk ddobrigk commented Dec 4, 2022

No description provided.

@ddobrigk ddobrigk requested review from a team, alibuild, iarsene, jgrosseo and ktf as code owners December 4, 2022 18:41
@ddobrigk ddobrigk enabled auto-merge (squash) December 4, 2022 18:42
alibuild
alibuild previously approved these changes Dec 4, 2022
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ddobrigk.

@ddobrigk ddobrigk disabled auto-merge December 4, 2022 18:48
@ddobrigk ddobrigk enabled auto-merge (squash) December 4, 2022 18:48
alibuild
alibuild previously approved these changes Dec 4, 2022
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ddobrigk.

@alibuild
Copy link
Collaborator

alibuild commented Dec 4, 2022

Error while checking build/O2Physics/o2 for ec7b4cb at 2022-12-04 19:51:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/1581-slc7_x86-64/0/Common/Tasks/propagatorQa.cxx:75:32: error: 'lBachUsed' may be used uninitialized in this function [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/1581-slc7_x86-64/0/Common/Tasks/propagatorQa.cxx:83:20: error: 'lNegUsed' may be used uninitialized in this function [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/1581-slc7_x86-64/0/Common/Tasks/propagatorQa.cxx:83:20: error: 'lPosUsed' may be used uninitialized in this function [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Dec 4, 2022

Error while checking build/O2Physics/o2 for 254e2bd at 2022-12-04 19:58:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/1581-slc7_x86-64/0/Common/Tasks/propagatorQa.cxx:75:32: error: 'lBachUsed' may be used uninitialized in this function [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/1581-slc7_x86-64/0/Common/Tasks/propagatorQa.cxx:83:20: error: 'lNegUsed' may be used uninitialized in this function [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/1581-slc7_x86-64/0/Common/Tasks/propagatorQa.cxx:83:20: error: 'lPosUsed' may be used uninitialized in this function [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

@ddobrigk ddobrigk disabled auto-merge December 4, 2022 19:02
@ddobrigk ddobrigk enabled auto-merge (squash) December 4, 2022 19:02
alibuild
alibuild approved these changes Dec 4, 2022
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ddobrigk.

@ddobrigk ddobrigk merged commit e4307a5 into AliceO2Group:master Dec 4, 2022
@ddobrigk ddobrigk deleted the propagatorqa branch December 22, 2022 09:41
ercolessi pushed a commit to ercolessi/O2Physics that referenced this pull request Jan 9, 2023
@ddobrigk @alibuild @ercolessi
Propagatorqa added for performance optimisations (AliceO2Group#1581)
23d5cab 
* Create propagatorQa.cxx

* Update CMakeLists.txt

* Please consider the following formatting changes

* re-trigger checks...

* Extra whitepace removal

* Bugfix

* Please consider the following formatting changes

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
GijsvWeelden pushed a commit to GijsvWeelden/O2Physics that referenced this pull request Jan 13, 2023
@ddobrigk @alibuild @GijsvWeelden
Propagatorqa added for performance optimisations (AliceO2Group#1581)
be31425 
* Create propagatorQa.cxx

* Update CMakeLists.txt

* Please consider the following formatting changes

* re-trigger checks...

* Extra whitepace removal

* Bugfix

* Please consider the following formatting changes

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
cimordas pushed a commit to cimordas/O2Physics that referenced this pull request Jan 20, 2023
@ddobrigk @alibuild @cimordas
Propagatorqa added for performance optimisations (AliceO2Group#1581)
825371a 
* Create propagatorQa.cxx

* Update CMakeLists.txt

* Please consider the following formatting changes

* re-trigger checks...

* Extra whitepace removal

* Bugfix

* Please consider the following formatting changes

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddobrigk @alibuild