Closed
Conversation
ZFederica
requested review from
alibuild,
cterrevo,
fcolamar,
ginnocen and
vkucera
as code owners
Please consider the following formatting changes to AliceO2Group#1593
Please consider the following formatting changes to AliceO2Group#1593
vkucera
requested changes
Dec 6, 2022
Collaborator
There was a problem hiding this comment.
Hi @ZFederica , thanks for this addition. There a several things to be fixed. Please check the HF coding and naming conventions.
Also use PROCESS_SWITCH instead of the command line doMC option (which would not be usable on AliHyperloop ).
Contributor
Author
|
Thanks @vkucera for your reply. I'll change to PROCESS_SWITCH and try to implement the code following all the conventions I find at https://aliceo2group.github.io/analysis-framework/docs/advanced-specifics/pwghf.html. Is there anything else I should read concerning the HF conventions? |
ZFederica
requested review from
a team,
BongHwi,
chiarapinto,
chiarazampolli,
ddobrigk,
iarsene,
iravasen,
jgrosseo,
ktf,
mbombara,
njacazio and
noferini
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.