Skip to content

Add zdc converter #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddobrigk merged 6 commits into from
Apr 13, 2023
Merged

Add zdc converter #2355

ddobrigk merged 6 commits into from
Apr 13, 2023

Conversation

@ddobrigk
Copy link
Collaborator

@ddobrigk ddobrigk commented Apr 8, 2023

No description provided.

@ddobrigk ddobrigk requested review from a team, alibuild, iarsene, jgrosseo and ktf as code owners April 8, 2023 18:13
@ddobrigk ddobrigk enabled auto-merge (squash) April 8, 2023 18:14
alibuild
alibuild previously approved these changes Apr 8, 2023
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ddobrigk.

@alibuild
Copy link
Collaborator

alibuild commented Apr 8, 2023

Error while checking build/O2Physics/o2 for 1e1eae8 at 2023-04-08 20:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:22:17: error: 'Zdcs_001' is not a member of 'o2::aod'
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:22:25: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:24:16: error: 'o2::aod::Zdcs_000' has not been declared
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:26:26: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:26:26: error: 'end' was not declared in this scope
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:98:15: error: expression cannot be used as a function
/sw/slc7_x86-64/O2/nightly-20230405-local3/include/Framework/ASoA.h:152:26: error: 'decayed' {aka 'int'} is not a class, struct, or union type
/sw/slc7_x86-64/O2/nightly-20230405-local3/include/Framework/ASoA.h:153:51: error: 'decayed' {aka 'int'} is not a class, struct, or union type
/sw/slc7_x86-64/O2/nightly-20230405-local3/include/Framework/AnalysisTask.h:234:55: error: too many braces around scalar initializer for type 'int'
/sw/slc7_x86-64/O2/nightly-20230405-local3/include/Framework/AnalysisTask.h:117:50: error: static assertion failed: Could not find metadata. Did you register your type?
/sw/slc7_x86-64/O2/nightly-20230405-local3/include/Framework/AnalysisTask.h:125:51: error: incomplete type 'metadata' {aka 'void'} used in nested name specifier
/sw/slc7_x86-64/O2/nightly-20230405-local3/include/Framework/AnalysisTask.h:125:71: error: incomplete type 'metadata' {aka 'void'} used in nested name specifier
/sw/slc7_x86-64/O2/nightly-20230405-local3/include/Framework/AnalysisTask.h:125:96: error: incomplete type 'metadata' {aka 'void'} used in nested name specifier
/sw/slc7_x86-64/O2/nightly-20230405-local3/include/Framework/AnalysisTask.h:125:117: error: incomplete type 'metadata' {aka 'void'} used in nested name specifier
/sw/slc7_x86-64/O2/nightly-20230405-local3/include/Framework/AnalysisTask.h:125:117: error: no matching function for call to 'o2::framework::InputSpec::InputSpec(<brace-enclosed initializer list>)'
ninja: build stopped: subcommand failed.

Full log here.

@ddobrigk ddobrigk marked this pull request as draft April 8, 2023 18:46
auto-merge was automatically disabled April 8, 2023 18:46

Pull request was converted to draft

@ddobrigk ddobrigk marked this pull request as ready for review April 10, 2023 18:53
@alibuild
Copy link
Collaborator

alibuild commented Apr 11, 2023

Error while checking build/O2Physics/o2 for 7f0cc34 at 2023-04-11 09:19:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:25:17: error: 'Zdcs_001' is not a member of 'o2::aod'
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:25:25: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:27:16: error: 'o2::aod::Zdcs_000' has not been declared
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:29:26: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:29:26: error: 'end' was not declared in this scope
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:101:15: error: expression cannot be used as a function
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/ASoA.h:152:26: error: 'decayed' {aka 'int'} is not a class, struct, or union type
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/ASoA.h:153:51: error: 'decayed' {aka 'int'} is not a class, struct, or union type
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:234:55: error: too many braces around scalar initializer for type 'int'
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:117:50: error: static assertion failed: Could not find metadata. Did you register your type?
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:125:51: error: incomplete type 'metadata' {aka 'void'} used in nested name specifier
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:125:71: error: incomplete type 'metadata' {aka 'void'} used in nested name specifier
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:125:96: error: incomplete type 'metadata' {aka 'void'} used in nested name specifier
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:125:117: error: incomplete type 'metadata' {aka 'void'} used in nested name specifier
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:125:117: error: no matching function for call to 'o2::framework::InputSpec::InputSpec(<brace-enclosed initializer list>)'
ninja: build stopped: subcommand failed.

Full log here.

@jgrosseo
Copy link
Contributor

jgrosseo commented Apr 11, 2023

@ddobrigk Why does this still fail? The O2 PR has been merged 5 days ago.

AliceO2Group/AliceO2#10973

@TimoWilken @ktf any clue?

@ddobrigk
Copy link
Collaborator Author

ddobrigk commented Apr 11, 2023

(I was indeed trying to figure out and about to ask why it doesn't find the new tables... Thanks!)

@alibuild
Copy link
Collaborator

alibuild commented Apr 12, 2023

Error while checking build/O2Physics/o2 for 6078814 at 2023-04-12 14:53:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:25:17: error: 'Zdcs_001' is not a member of 'o2::aod'
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:25:25: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:27:16: error: 'o2::aod::Zdcs_000' has not been declared
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:29:26: error: 'begin' was not declared in this scope
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:29:26: error: 'end' was not declared in this scope
/sw/SOURCES/O2Physics/2355-slc7_x86-64/0/Common/TableProducer/zdcConverter.cxx:101:15: error: expression cannot be used as a function
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/ASoA.h:152:26: error: 'decayed' {aka 'int'} is not a class, struct, or union type
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/ASoA.h:153:51: error: 'decayed' {aka 'int'} is not a class, struct, or union type
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:234:55: error: too many braces around scalar initializer for type 'int'
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:117:50: error: static assertion failed: Could not find metadata. Did you register your type?
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:125:51: error: incomplete type 'metadata' {aka 'void'} used in nested name specifier
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:125:71: error: incomplete type 'metadata' {aka 'void'} used in nested name specifier
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:125:96: error: incomplete type 'metadata' {aka 'void'} used in nested name specifier
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:125:117: error: incomplete type 'metadata' {aka 'void'} used in nested name specifier
/sw/slc7_x86-64/O2/nightly-20230405-local4/include/Framework/AnalysisTask.h:125:117: error: no matching function for call to 'o2::framework::InputSpec::InputSpec(<brace-enclosed initializer list>)'
ninja: build stopped: subcommand failed.

Full log here.

@TimoWilken
Copy link
Contributor

TimoWilken commented Apr 12, 2023

Why does this still fail? The O2 PR has been merged 5 days ago.

Hi @jgrosseo @ddobrigk, sorry about that, apparently the nightly updates of O2 in alidist weren't merged. I've done that and restarted the checks here.

@ddobrigk ddobrigk enabled auto-merge (squash) April 13, 2023 08:53
alibuild
alibuild approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ddobrigk.

@ddobrigk ddobrigk merged commit 5410e8f into AliceO2Group:master Apr 13, 2023
AlexBigO pushed a commit to AlexBigO/O2Physics that referenced this pull request Apr 21, 2023
@ddobrigk @alibuild
Add zdc converter (AliceO2Group#2355)
c5bc399 
* Add zdc converter

* Please consider the following formatting changes (AliceO2Group#94)

* retrigger CI

* Please consider the following formatting changes (AliceO2Group#95)

---------

Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddobrigk @alibuild @jgrosseo @TimoWilken