Skip to content

Cascade Task Update #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChiaraDeMartin95 merged 8 commits into from
Jun 29, 2023
Merged

Cascade Task Update #2885

ChiaraDeMartin95 merged 8 commits into from
Jun 29, 2023

Conversation

@nepeivodaRS
Copy link
Contributor

@nepeivodaRS nepeivodaRS commented Jun 23, 2023 •
edited
Loading

  1. Mult configurable axes
  2. TPC pT axes
  3. Fix hNEvents histo type.
  4. Nch vs Signal in FT0M/FV0A. NOT finished - no histogram for MC (several reconstructed collisions for the one generated one)

nepeivodaRS and others added 5 commits June 23, 2023 23:08
@nepeivodaRS
BranchInit
43b5dfa 
1. Mult axis
2. TPC pt axis
3. FIx Nevents precision bug
4. Nch vs Signal in FT0M/FV0A
@nepeivodaRS
Upd Mult and Cut hists
9287765
@alibuild
Please consider the following formatting changes
44af51c
@nepeivodaRS
Merge pull request #4 from alibuild/alibot-cleanup-2885
d25ab49 
Please consider the following formatting changes to #2885
@nepeivodaRS
del isFT0MforMC for rec. hists
fb64c94
ChiaraDeMartin95
ChiaraDeMartin95 reviewed Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@ChiaraDeMartin95 ChiaraDeMartin95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add the possibility to select the zvertex of the collision in the cascpostprocessing? Haveing a configurable variable would be perfect.

PWGLF/TableProducer/cascqaanalysis.cxx Outdated
AxisSpec rapidityAxis = {200, -2.0f, 2.0f, "y"};
AxisSpec centFT0MAxis = {100, 0.0f, 100.0f, "FT0M (%)"};
ConfigurableAxis centFT0MAxis{"FT0M",
{VARIABLE_WIDTH, 0., 0.01, 0.1, 0.5, 1, 5, 10, 15, 20, 25, 30, 35, 40, 50, 70, 100},
Copy link
Collaborator

@ChiaraDeMartin95 ChiaraDeMartin95 Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add 0.05 and 45, 55, 60, 65, 75 and so on in bins of 5% up to 100? We might want to have a look at lower multiplicities as well at a certain point.

PWGLF/TableProducer/cascqaanalysis.cxx Outdated
registry.add("hDCAxy_BefCut", "hDCAxy_BefCut", HistType::kTH2F, {{400, -0.2, 0.2, "DCAxy"}, {150, 0.0, 15.0, "p_{T} (GeV/c)"}});
registry.add("hDCAxy_AfterCut", "hDCAxy_AfterCut", HistType::kTH2F, {{400, -0.2, 0.2, "DCAxy"}, {150, 0.0, 15.0, "p_{T} (GeV/c)"}});
registry.add("hNchMultFT0M", "hNchMultFT0M", HistType::kTH2F, {{150, 0.f, 150.f, "N_{ch}"}, {10000, 0.f, 10000.f, "FT0M signal"}});
registry.add("hNchMultFV0A", "hNchMultFV0A", HistType::kTH2F, {{150, 0.f, 150.f, "N_{ch}"}, {10000, 0.f, 10000.f, "FV0A signal"}});
Copy link
Collaborator

@ChiaraDeMartin95 ChiaraDeMartin95 Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you checked if these intervals cover the whole distribution?

Copy link
Contributor Author

@nepeivodaRS nepeivodaRS Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the FT0M and FV0A I just inherited the max from O2Physics/Common/Tasks/multiplicityQa.cxx. Nevertheless, it could be more reasonable to have kTProfile in Mult axis to get the average signal in FT0M/FV0A for each multiplicity in the event: that will help with the binning issue (at least for the Mult axis). For the Nch one - idk what to expect in VHM events, so we can put 1k for it if you agree.

PWGLF/Tasks/cascpostprocessing.cxx Outdated
AxisSpec centFT0MAxis = {100, 0.0f, 100.0f, "FT0M (%)"};
AxisSpec centFV0AAxis = {100, 0.0f, 100.0f, "FV0A (%)"};
ConfigurableAxis centFT0MAxis{"FT0M",
{VARIABLE_WIDTH, 0., 0.01, 0.1, 0.5, 1, 5, 10, 15, 20, 25, 30, 35, 40, 50, 70, 100},
Copy link
Collaborator

@ChiaraDeMartin95 ChiaraDeMartin95 Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as before

PWGLF/Tasks/cascpostprocessing.cxx
registry.fill(HIST("hCascCosPA"), candidate.pt(), candidate.casccospa());
registry.fill(HIST("hV0CosPA"), candidate.pt(), candidate.v0cospa());
registry.fill(HIST("hCascRadius"), candidate.pt(), candidate.cascradius());
registry.fill(HIST("hV0Radius"), candidate.pt(), candidate.v0radius());
Copy link
Collaborator

@ChiaraDeMartin95 ChiaraDeMartin95 Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can add the second axis (pt) for all topological variables. Maybe you can define ptAxisTopoVar with bins of 200 MeV each, and not 50 MeV each (50 bins in total from 0 to 10 GeV).

nepeivodaRS and others added 3 commits June 29, 2023 00:48
@nepeivodaRS
Upd
dbb0a2b 
1. Implement Chiara's suggestions
2. hNAssocCollisions
3. hNContributorsCorrelation for the case when there're 2 rec. collisions for the 1 gen.
@alibuild
Please consider the following formatting changes
ad99c07
@nepeivodaRS
Merge pull request #5 from alibuild/alibot-cleanup-2885
86d63cb 
Please consider the following formatting changes to #2885
@nepeivodaRS nepeivodaRS marked this pull request as ready for review June 29, 2023 08:14
@ChiaraDeMartin95 ChiaraDeMartin95 enabled auto-merge (squash) June 29, 2023 09:07
@ChiaraDeMartin95 ChiaraDeMartin95 merged commit c4c0af3 into AliceO2Group:master Jun 29, 2023
@nepeivodaRS nepeivodaRS deleted the cascQAupdate branch July 10, 2023 09:51
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Jul 11, 2023
@nepeivodaRS @alibuild @hahassan7
Cascade Task Update (AliceO2Group#2885)
73fa754 
* BranchInit

1. Mult axis
2. TPC pt axis
3. FIx Nevents precision bug
4. Nch vs Signal in FT0M/FV0A

* Upd Mult and Cut hists

* Please consider the following formatting changes

* del isFT0MforMC for rec. hists

* Upd

1. Implement Chiara's suggestions
2. hNAssocCollisions
3. hNContributorsCorrelation for the case when there're 2 rec. collisions for the 1 gen.

* Please consider the following formatting changes

---------

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Oct 7, 2023
@nepeivodaRS @alibuild @hahassan7
Cascade Task Update (AliceO2Group#2885)
04a3bcd 
* BranchInit

1. Mult axis
2. TPC pt axis
3. FIx Nevents precision bug
4. Nch vs Signal in FT0M/FV0A

* Upd Mult and Cut hists

* Please consider the following formatting changes

* del isFT0MforMC for rec. hists

* Upd

1. Implement Chiara's suggestions
2. hNAssocCollisions
3. hNContributorsCorrelation for the case when there're 2 rec. collisions for the 1 gen.

* Please consider the following formatting changes

---------

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
zconesa pushed a commit to zconesa/O2Physics that referenced this pull request Oct 27, 2023
@nepeivodaRS @alibuild @zconesa
Cascade Task Update (AliceO2Group#2885)
9ab44da 
* BranchInit

1. Mult axis
2. TPC pt axis
3. FIx Nevents precision bug
4. Nch vs Signal in FT0M/FV0A

* Upd Mult and Cut hists

* Please consider the following formatting changes

* del isFT0MforMC for rec. hists

* Upd

1. Implement Chiara's suggestions
2. hNAssocCollisions
3. hNContributorsCorrelation for the case when there're 2 rec. collisions for the 1 gen.

* Please consider the following formatting changes

---------

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
chengtt0406 pushed a commit to chengtt0406/O2Physics that referenced this pull request Dec 6, 2023
@nepeivodaRS @alibuild @chengtt0406
Cascade Task Update (AliceO2Group#2885)
a912163 
* BranchInit

1. Mult axis
2. TPC pt axis
3. FIx Nevents precision bug
4. Nch vs Signal in FT0M/FV0A

* Upd Mult and Cut hists

* Please consider the following formatting changes

* del isFT0MforMC for rec. hists

* Upd

1. Implement Chiara's suggestions
2. hNAssocCollisions
3. hNContributorsCorrelation for the case when there're 2 rec. collisions for the 1 gen.

* Please consider the following formatting changes

---------

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChiaraDeMartin95 ChiaraDeMartin95 ChiaraDeMartin95 approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@lramona lramona Awaiting requested review from lramona

@lbariogl lbariogl Awaiting requested review from lbariogl

@chiarapinto chiarapinto Awaiting requested review from chiarapinto

@BongHwi BongHwi Awaiting requested review from BongHwi

@mbombara mbombara Awaiting requested review from mbombara

@iravasen iravasen Awaiting requested review from iravasen

@njacazio njacazio Awaiting requested review from njacazio

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nepeivodaRS @ChiaraDeMartin95 @alibuild